Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ck_hclh test gets stuck #141

Closed
bmwiedemann opened this issue Jun 17, 2019 · 6 comments

Comments

Projects
None yet
2 participants
@bmwiedemann
Copy link

commented Jun 17, 2019

While working on reproducible builds for openSUSE, I found that
the ck_hclh test gets stuck forever on 1-CPU (KVM) builds

[  133s] Waiting for threads to finish correctness regression...done (passed)
[  133s] ./ck_hclh 1 1
[  133s] Creating threads (mutual exclusion)...done
[243038s] Waiting for threads to finish correctness regression...

Steps to reproduce on openSUSE or Debian:

osc checkout openSUSE:Factory/ck && cd $_
osc build --noservice -j1 --clean

Version: ck-0.6.0 ; same problem with 0.7.0

@cognet

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

Hi,

Indeed, the test was broken with CORES=1. I just pushed a fix, can you confirm it now works for you ?

Thanks !

@bmwiedemann

This comment has been minimized.

Copy link
Author

commented Jun 17, 2019

With commit fd55609 the test passes now.
However, it is not obvious if the changed value of line 7 also applied to line 4's local_lock[CORES / 2]

A quick test with gcc -E shows that it does, but would have been nice to have it more obvious.

@cognet

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

You're right, I'll move it before line 4

@bmwiedemann

This comment has been minimized.

Copy link
Author

commented Jun 17, 2019

For reference: fa63a95

looks good.
Will there be a new release before 2020 or should I consider to add the patch to our package?

@cognet

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

I can't tell for sure, but given the low number of commits done since last release, if I were you I wouldn't expect a new release before 2020.

@bmwiedemann

This comment has been minimized.

Copy link
Author

commented Jun 18, 2019

Thank you.
I submitted the fix as a patch to openSUSE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.