-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add win #7
add win #7
Conversation
…da-forge-pinning 2019.11.13
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
include_directories("${PROJECT_BINARY_DIR}") | ||
include_directories(${HEADERS_DIR}) | ||
|
||
add_library(libcunit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As cunit is required by Cyclone DDS and is searched in https://github.com/eclipse-cyclonedds/cyclonedds/blob/48ad8dfe7b10ccf07c83f4394e2b23fc75ce9627/cmake/Modules/FindCUnit.cmake#L41 , I would ensure that the library is called cunit
on Windows instead of libcunit, as otherwise the find_library(CUNIT_LIBRARY cunit)
will fail on Windows (as the lib
prefix is only added in the search process on Unix, not on Windows).
More in general, if you are interested in this for ROS2/Cyclone DDS compatibility, we could look into using the same CMake script they use for ROS2 cunit builds: https://github.com/ros2/choco-packages/blob/3c6b2741cfec72487257d6a064e886cb6245d2b3/package/cunit/build/CMakeLists.txt .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is an extremely helpful comment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will use the ROS cmake then
@conda-forge-admin please restart ci |
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
superseded by #10 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)