Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add win #7

Closed
wants to merge 4 commits into from
Closed

add win #7

wants to merge 4 commits into from

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Nov 15, 2019

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • There are too few lines. There should be one empty line at the end of the file.

For recipe:

  • license_file entry is missing, but is expected.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

include_directories("${PROJECT_BINARY_DIR}")
include_directories(${HEADERS_DIR})

add_library(libcunit

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As cunit is required by Cyclone DDS and is searched in https://github.com/eclipse-cyclonedds/cyclonedds/blob/48ad8dfe7b10ccf07c83f4394e2b23fc75ce9627/cmake/Modules/FindCUnit.cmake#L41 , I would ensure that the library is called cunit on Windows instead of libcunit, as otherwise the find_library(CUNIT_LIBRARY cunit) will fail on Windows (as the lib prefix is only added in the search process on Unix, not on Windows).

More in general, if you are interested in this for ROS2/Cyclone DDS compatibility, we could look into using the same CMake script they use for ROS2 cunit builds: https://github.com/ros2/choco-packages/blob/3c6b2741cfec72487257d6a064e886cb6245d2b3/package/cunit/build/CMakeLists.txt .

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is an extremely helpful comment!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will use the ROS cmake then

@Tobias-Fischer Tobias-Fischer mentioned this pull request Apr 21, 2021
5 tasks
@Tobias-Fischer
Copy link
Contributor

@conda-forge-admin please restart ci

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@wolfv wolfv closed this Apr 21, 2021
@wolfv
Copy link
Member Author

wolfv commented Apr 21, 2021

superseded by #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants