-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the toolchain
to build
#40
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This passes on Travis CI. It is clean of |
Since you guys are set to force numpy+openblas down the stack the only safe solution is to add the The alternative that I am proposing is to pull numpy+openblas from the What I am proposing is an incremental way forward that will ensure stability of the stack. Ping: @pelson, @gillins, @msarahan, and @kmuehlbauer. |
How are you guys using C++ in |
I have merged this, as I believe it does incrementally improve the current situation (no longer linking to libstdc++). There is a philosophical question which we will be discussing tomorrow as to whether we want to be pulling in the |
👍 I assume you are in a better position to answer the above question as well.
👍 Though I know I don't have the bandwidth to help keep all those flags straight, which was one of the motivators for creating the Feel free to discuss. Unfortunately, as mentioned on gitter, I won't be able to make it to a meeting tomorrow. I'd request that we hold off on a decision on this important issue until I can be present. |
Perfectly reasonable. Will do. |
Fixes #39
So,
matplotlib
was not using thetoolchain
previously (has been around for quite awhile), but has C++ code. As discussed in this issue ( conda-forge/conda-forge.github.io#183 ), we need to be usinglibc++
on Mac. However, it appears some shadowing is happening additionally as suggested by this report ( #39 ). This switchesmatplotlib
over tolibc++
and thus should resolve these issues.