-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noarch package #33
Noarch package #33
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.06.27.18.30.08
Comments from PR #32
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
For recipe:
|
recipe/meta.yaml
Outdated
@@ -12,16 +12,14 @@ source: | |||
sha256: {{ sha256 }} | |||
|
|||
build: | |||
number: 0 | |||
number: 1 | |||
noarch: python | |||
script: python setup.py install --single-version-externally-managed --record record.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be rewritten as
script: {{ PYTHON }} -m pip install . --no-deps -vv
(possibly change requirements.host setuptools --> pip)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no-deps will not work as we need MDA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that already defined under run
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you're right... Do we need the --single-version-externally-managed --record record.txt
options for something??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to use pip.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.06.27.18.30.08
I'll probably close my manual attempt here and let conda-smithy do everything in PR #34 ... |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Following https://conda-forge.org/docs/maintainer/adding_pkgs.html#use-pip, `pip` should be in `host.requirements`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me, I don't understand thing enough to be 100% sure, but the best thing we can do is test it out and see what happens.
Change mdanalysistests into a noarch package (see MDAnalysis/mdanalysis#3727)
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)