Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miniforge Docker images #2

Merged
merged 12 commits into from Feb 8, 2021
Merged

Miniforge Docker images #2

merged 12 commits into from Feb 8, 2021

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Feb 7, 2021 •
edited

This moves the condaforge/miniforge3 and condaforge/mambaforge image over from https://github.com/conda-forge/docker-images and introduces image versioning.

yuvipanda and others added 9 commits February 7, 2021 14:12
@yuvipanda @xhochy
Add miniforge3 simple base image
7a13a9a 
A slim miniforge3 image, equivalent to miniconda3 but with some
slightly different choices.

- Use ubuntu LTS as base instead of debian
- Keep $HOME clean, so folks can mount volumes into it

Ref conda-forge/miniforge#20
@yuvipanda @xhochy
Activate base by default in bash shells
69ae0ba 
- Put activate commands in user's .bashrc, since this is where
  PS1 is set. If we put the activate commands in /etc/bash.bashrc,
  the environments are set up properly but PS1 is not. This
  is very confusing.
- Put activate commands in /etc/skel as well, so any new non-root
  users created also get base activated by default
- Stop using 'login' shells, as they are no longer needed.
@yuvipanda @xhochy
Don't put .wget-hsts files in $HOME
60e43d7
@yuvipanda @xhochy
Add minimal tests for miniforge3
13261a5
@yuvipanda @xhochy
Add tests as non-root as well
c43fda5
@yuvipanda @xhochy
Actually fail the build when test fails
48c02d8
@yuvipanda @xhochy
Fix clean-home test for non-root users
e3dfcb5
@yuvipanda @xhochy
Add newlines to end of all files
040e9ff
@xhochy
Move into docker/
471b0f2
@xhochy xhochy force-pushed the docker-images branch 15 times, most recently from ba311a2 to f5105fe Compare February 7, 2021 19:57
@xhochy xhochy marked this pull request as ready for review February 7, 2021 20:12
@xhochy
Copy link
Member Author

xhochy commented Feb 7, 2021

@conda-forge/core This is ready for review. Secrets are yet missing from this repository but otherwise this works. Multi-platform builds with docker seems like fun.

@xhochy xhochy mentioned this pull request Feb 8, 2021
Closed
@jakirkham
Copy link
Member

Thanks Uwe! 😀

Does this squash images? Less familiar with the buildx subcommand

@jakirkham jakirkham mentioned this pull request Feb 8, 2021
Closed
@xhochy
Copy link
Member Author

xhochy commented Feb 8, 2021 •
edited

Thanks Uwe! 😀

Does this squash images? Less familiar with the buildx subcommand

No, you cannot squash with buildx, you cannot build multiplatform images with docker build, and so on. I had quite a rage at the fragmentation of the docker/moby build infrastructure while doing this PR. This PR is the compromise of what I could get out of that fragmentated ecosystem.

(I put buildah on my list of things to learn but didn't get to it)

@xhochy xhochy mentioned this pull request Feb 8, 2021
Merged
@jakirkham
Copy link
Member

Gotcha. Did you want to handle secrets here or in another PR?

@xhochy
Copy link
Member Author

xhochy commented Feb 8, 2021

Gotcha. Did you want to handle secrets here or in another PR?

No, added them all now.

@beckermr
Copy link
Member

beckermr commented Feb 8, 2021

Have we considered moving this to azure?

@xhochy
Copy link
Member Author

xhochy commented Feb 8, 2021

Have we considered moving this to azure?

No, I kept this on Github Actions as it was before. Happy to do that in a follow-up PR once this one is working.

@jakirkham
Copy link
Member

Just curious, is there a reason we want to move to Azure? Have no preference personally

@beckermr
Copy link
Member

beckermr commented Feb 8, 2021

We have more workers there and these jobs are long.

@xhochy
Copy link
Member Author

xhochy commented Feb 8, 2021

@beckermr In preparation for the follow-up PR: Can you setup the credentials in Azure? I have no access there.

@beckermr
Copy link
Member

beckermr commented Feb 8, 2021

Yes!

@xhochy
Copy link
Member Author

xhochy commented Feb 8, 2021

Pushed this branch with changed accounts to master on my fork: https://github.com/xhochy/miniforge-images/runs/1857817921, you can see the final images at https://hub.docker.com/repository/docker/xhochy/mambaforge

@jakirkham jakirkham merged commit 5179db8 into conda-forge:master Feb 8, 2021
@jakirkham
Copy link
Member

Thanks Uwe! 😄 Went ahead and merged. Let's handle the Azure bits in a new PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xhochy @jakirkham @beckermr @yuvipanda