Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to mamba=0.7.12 #110

Merged
merged 2 commits into from
Feb 10, 2021
Merged

Update to mamba=0.7.12 #110

merged 2 commits into from
Feb 10, 2021

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Feb 9, 2021

We currently ship an older mamba release which has issues with private channels, updating to the latest release fixes these.

I added an explicit pin for the mamba version to improve reproducibility.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Feb 9, 2021

the explicit pin will cause us to forget to move it forward.

is >= better?

@wolfv
Copy link
Member

wolfv commented Feb 9, 2021

maybe not pin a version on ppc64le because sometimes the builds fail on Travis. I can be more careful to not merge when they do from now on ...

@xhochy
Copy link
Member Author

xhochy commented Feb 9, 2021

Actually I would like to have the pin to detect that we don't support a current mamba release on all platforms. Like the CI result tells us currently.

I would prefer to keep the pin and rather have a cron job that opens a PR that updates the pin instead. Not sure whether we should do that via Github Actions or the cf-scripts (cc @conda-forge/bot).

@xhochy
Copy link
Member Author

xhochy commented Feb 9, 2021

Using mamba to get a better error message doesn't help.

$ CONDA_SUBDIR=linux-ppc64le mamba create -n mambatest mamba=0.7.12 pypy

Looking for: ['mamba=0.7.12', 'pypy']

conda-forge/noarch       Using cache
conda-forge/linux-ppc64l [====================] (00m:00s) Done
Encountered problems while solving.
Problem: nothing provides python 3.6.9 1_73_pypy needed by pypy-7.3.1-h9f0ad1d_1

@xhochy xhochy closed this Feb 10, 2021
@xhochy xhochy reopened this Feb 10, 2021
@xhochy
Copy link
Member Author

xhochy commented Feb 10, 2021

CI is green, we should either merge this or continue the discussion on the mamba pinning.

@xhochy xhochy requested a review from a team February 10, 2021 16:04
@isuruf isuruf merged commit 65277cd into conda-forge:master Feb 10, 2021
@xhochy xhochy deleted the update-mamba branch February 11, 2021 13:13
@xhochy
Copy link
Member Author

xhochy commented Feb 17, 2021

@conda-forge/miniforge Can we tag this as a release? That would be nice as I run into a bug with custom channels and the setup-miniconda action with mamba here. I have workarounds but a tag would clean my workflows up greatly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants