Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to auto-update mamba #117

Merged
merged 2 commits into from
Mar 5, 2021
Merged

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Feb 18, 2021

Fixes #116

This checks every 6h whether there is a new conda / mamba release and makes a PR that updates the Miniforge3/construct.yaml file.

Important things:

  • Only opens a single PR and only if there are changes. If there is an open PR with conflicting changes, it won't do anything.
  • If the PR was closed, it will delete the branch and recreate it with new commits.
  • The commit will be pushed using a repo-specific deploy key. If the commit were pushed using the normal ${{ GITHUB_TOKEN }}, CI wouldn't be triggered. As the deploy key is specific to this repo, it doesn't give anyone in the miniforge team more permissions that they would already have.
  • I have added the deploy key to the repo and will also add it in the usual place in keybase.

See xhochy/miniforge-bot#3 for a working example of this change.

@xhochy xhochy requested a review from a team as a code owner February 18, 2021 08:42
@isuruf
Copy link
Member

isuruf commented Feb 19, 2021

For a new conda version, this would require 3 * 20 CI jobs instead of 20 CI jobs?

@xhochy
Copy link
Member Author

xhochy commented Feb 19, 2021

For a new conda version, this would require 3 * 20 CI jobs instead of 20 CI jobs?

Yes, this is the cost of this automation but it also means that we tests were run before we set the tag.

@xhochy
Copy link
Member Author

xhochy commented Feb 23, 2021

@isuruf Anything I can do to get this merged?

@isuruf
Copy link
Member

isuruf commented Feb 23, 2021

Can we do it for mamba version only? (Maybe open an issue for conda version. I don't see any point to creating a PR, merging it and tagging vs just tagging)

@xhochy
Copy link
Member Author

xhochy commented Feb 23, 2021

Maybe open an issue for conda version

You mean that we could have a bot that opens an issue for a new conda version?

@isuruf
Copy link
Member

isuruf commented Feb 23, 2021

You mean that we could have a bot that opens an issue for a new conda version?

Yes an issue asking for a new tag.

@xhochy
Copy link
Member Author

xhochy commented Mar 5, 2021

Added an action for a tag over at #132

Can this here be merged, too?

@isuruf isuruf merged commit 8e0483f into conda-forge:master Mar 5, 2021
@xhochy xhochy deleted the autoupdate branch March 6, 2021 11:22
@xhochy xhochy changed the title Add action to auto-update conda & mamba Add action to auto-update mamba Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Automatic PRs for conda and mamba updates
2 participants