Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builds of openpyxl=2.4.5 are broken #1

Closed
jorisvandenbossche opened this issue Apr 2, 2017 · 12 comments

Comments

Projects
None yet
4 participants
@jorisvandenbossche
Copy link

commented Apr 2, 2017

See https://bitbucket.org/openpyxl/openpyxl/issues/790/conda-forge-builds-of-openpyxl-245-are (which caused errors in the pandas tests). Apparently some deps are missing.

@jreback

This comment has been minimized.

Copy link

commented Apr 2, 2017

i did look for this recipe

it's missing jdcal as a dependency
the import tests don't catch this apparently

@jreback

This comment has been minimized.

Copy link

commented Apr 2, 2017

@curtisalexander

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2017

@curtisalexander

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2017

@jreback @jorisvandenbossche Apologies for the broken build. All this is new to me - I added back the dependencies to the meta.yaml file and updated the build number. Do you all know how I can trigger a rebuild of the packages? Do I need to use conda-smithy to re-render the files for the CI services? If so, I won't be able to do so until late Wed. as I am away from home and my development machine (typing this on my phone). Or if one of you want to fork and submit a PR, I will merge.

@jorisvandenbossche

This comment has been minimized.

Copy link
Author

commented Apr 3, 2017

@curtisalexander No problem!
New builds are triggered automatically when you commit something, and the builds will also be updated on the conda-forge package repo if you increase the build number, which you did.
You can see here that there are new packages uploaded: https://anaconda.org/conda-forge/openpyxl/files

@jreback

This comment has been minimized.

Copy link

commented Apr 3, 2017

thanks @curtisalexander

(pandas) bash-3.2$ conda create -n test python=3.6 openpyxl -c conda-forge --dry
Fetching package metadata ...........
Solving package specifications: .

Package plan for installation in environment /Users/jreback/miniconda3/envs/test:

The following NEW packages will be INSTALLED:

    ca-certificates: 2017.1.23-0      conda-forge
    certifi:         2017.1.23-py36_0 conda-forge
    et_xmlfile:      1.0.1-py36_0     defaults   
    jdcal:           1.3-py36_0       defaults   
    ncurses:         5.9-10           conda-forge
    openpyxl:        2.4.5-py36_1     conda-forge
    openssl:         1.0.2h-3         conda-forge
    pip:             9.0.1-py36_0     conda-forge
    python:          3.6.1-0          conda-forge
    readline:        6.2-0            conda-forge
    setuptools:      33.1.1-py36_0    conda-forge
    sqlite:          3.13.0-1         conda-forge
    tk:              8.5.19-1         conda-forge
    wheel:           0.29.0-py36_0    conda-forge
    xz:              5.2.2-0          conda-forge
    zlib:            1.2.11-0         conda-forge

you may want to submit recipes for jdcal/et_xmlfile. typically conda-forge wants to be self-sufficient for all dependencies (even though they may be available on defaults).

@jreback

This comment has been minimized.

Copy link

commented Apr 3, 2017

you may want to submit recipes for jdcal/et_xmlfile. typically conda-forge wants to be self-sufficient for all dependencies (even though they may be available on defaults).

cc @jakirkham is this accurate?

@curtisalexander

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2017

@jakirkham @jreback Ok, I can create builds for both later this week.

@jorisvandenbossche @jreback Can you all confirm that the inclusion of the dependencies fixes the original issue?

Thanks.

@jakirkham

This comment has been minimized.

Copy link
Member

commented Apr 3, 2017

Yes, that is accurate @jreback, but it is ok to fallback to defaults if needed. We just encourage minimal reliance on defaults. Would add there are plenty of incentives for packaging things at conda-forge so it doesn't end up being something we have to push to hard.

@jorisvandenbossche

This comment has been minimized.

Copy link
Author

commented Apr 3, 2017

@jorisvandenbossche @jreback Can you all confirm that the inclusion of the dependencies fixes the original issue?

Yes it did!

@jreback

This comment has been minimized.

Copy link

commented Apr 3, 2017

thanks!

@curtisalexander

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2017

Thanks all.

65a6133 closes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.