Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate tests into a scipy-tests package #160

Closed
1 task done
xhochy opened this issue Feb 28, 2021 · 5 comments · Fixed by #184
Closed
1 task done

Separate tests into a scipy-tests package #160

xhochy opened this issue Feb 28, 2021 · 5 comments · Fixed by #184

Comments

@xhochy
Copy link
Member

xhochy commented Feb 28, 2021

The tests in the scipy package are quite large (11MiB on-disk size). Thus it would be nice if we could ship them in a separate conda package like we did for pyarrow: https://github.com/conda-forge/arrow-cpp-feedstock/blob/48de7951f41b685cd1112e2f85c7c016eac0f553/recipe/meta.yaml#L232 This would allow downstream consumers to still run the scipy tests in their environment but allow those that don't want to do this to not ship the tests at all.

@rgommers
Copy link
Contributor

If I understand the SP_DIR bit correctly, the separate arrow-tests package installs files into the same location as where the files for arrow are, not in a separate top-level directory. Is that correct? If so, separating seems doable. Otherwise it would be a fair bit of surgery, e.g. there's extensive use of dirname(__file__) in the tests.

@jakirkham
Copy link
Member

Yeah exactly. Split packages are just a way to divide up what was installed into smaller pieces

Agree moving files around would complicate things unnecessarily

@rgommers
Copy link
Contributor

Assuming this works, sounds fine to me. We'll have to document this and perhaps adjust scipy._lib._testutils.PytestTester to ensure it behaves nicely if someone calls scipy.test() or scipy.some_submodule.test().

@xhochy
Copy link
Member Author

xhochy commented Feb 28, 2021

Should these simply return an error with the information to install scipy-tests in that case?

@rgommers
Copy link
Contributor

Yes that sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants