Add IPython-SQL to conda-forge #1192

sodre · 2016-08-06T19:06:30Z

Please add iPython-SQL to conda-forge.

conda-forge-linter · 2016-08-06T19:06:35Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ipython-sql) and found some lint.

Here's what I've got...

For recipes/ipython-sql:

Failed to even lint the recipe (might be a conda-smithy bug) 😢

jakirkham · 2016-08-06T19:10:57Z

recipes/ipython-sql/meta.yaml

@@ -0,0 +1,46 @@
+{$ set version = "0.3.6" %}


Should be {% set version = "0.3.6" %}.

Small punctuation is our downfall again. 😆

jakirkham · 2016-08-06T19:15:43Z

Looks pretty good @sodre. Few things to fix up, but they are all pretty easy. Thanks for the proposed addition.

conda-forge-linter · 2016-08-06T19:17:11Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ipython-sql) and found it was in an excellent condition.

msarahan · 2016-08-06T19:30:21Z

Circle failure appears related to trying to compile pexpect python3 file. I think/hope newer versions of conda-build will fix this. Not sure if you want to try with 1.21.11 from source, package seems to not be available yet.

jakirkham · 2016-08-06T19:31:04Z

Didn't pip also work in this case?

sodre · 2016-08-06T19:33:08Z

let me know what/if you need me to change.

jakirkham · 2016-08-06T20:14:27Z

recipes/ipython-sql/meta.yaml

+  md5: {{ md5 }}
+
+build:
+  number: 0


Well, if you want to just do Python 3.x, please add skip: true # [py2k]. If we need Python 3.5 only, we may need to change py2k to py35. Once this is done, please drop the changes to .CI/build_all from the PR.

Guessing this is not needed now, but have forgotten. Maybe a reminder would be nice please. 😁

conda-forge-linter · 2016-08-06T22:36:13Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ipython-sql) and found some lint.

Here's what I've got...

For recipes/ipython-sql:

Failed to even lint the recipe (might be a conda-smithy bug) 😢

jakirkham · 2016-08-06T22:37:38Z

recipes/ipython-sql/meta.yaml

+  script: python setup.py install --single-version-externally-managed --record record.txt
+
+skip:
+  true # [py2k]


So this should be in the build section, it should be one line, and the selector should have at least 2 spaces before it.

@jakirkham,
Thanks so much for helping me out on this. is there an easy way to run the lint checker on my side before committing?

conda-forge-linter · 2016-08-06T22:42:54Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ipython-sql) and found some lint.

Here's what I've got...

For recipes/ipython-sql:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

conda-forge-linter · 2016-08-06T23:14:14Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ipython-sql) and found it was in an excellent condition.

jakirkham · 2016-08-08T02:19:38Z

recipes/ipython-sql/meta.yaml

+build:
+  number: 0
+  script: python setup.py install --single-version-externally-managed --record record.txt
+  skip: true  # [py2k]


We should be able to drop this skip line as conda-build version 1.21.11 is out and shouldn't run into the same issues.

jakirkham · 2016-08-08T03:46:05Z

Hmm...seems we are still running into this issue on CircleCI still, but not the other CIs. Will try rebuilding the Docker image.

As for the other CIs, seems we may be running into some other sort of issue ( spyder-ide/spyder#3309 ). @ccordoba12, do you know anything about what is causing the AttributeError: module 'pkg_resources' has no attribute 'iter_entry_points'. It seems to only occur on Python 3.5. 😕

jakirkham · 2016-08-08T04:20:02Z

Interestingly I don't run into this issue with setuptools alone or with pygments for that matter. There is something more going on that seems to be missing.

jakirkham · 2016-08-08T04:34:21Z

Rebuilt the Docker container and now restarting CircleCI.

jakirkham · 2016-08-08T04:34:36Z

@conda-forge/pygments, any ideas on this last error?

jakirkham · 2016-08-08T04:43:13Z

As for the first error, could you please try updating master for the conda-forge remote and merging with it, @sodre? I expect this should fix it.

ccordoba12 · 2016-08-08T14:35:48Z

@jakirkham, @Carreau said in spyder-ide/spyder#3309 that this problem was a bug in IPython 5.0, and that it'll be fixed in 5.1.

jakirkham · 2016-08-08T14:43:38Z

Ah, ok, sorry for being dense. Thanks for clarifying, @ccordoba12.

Carreau · 2016-08-08T18:43:18Z

Yes, Sorry I'm trying to push 5.1 / 5.0.1 through the door. I'm doing the best I can. Sorry about that.

jakirkham · 2016-08-08T19:23:00Z

No worries. Just trying to narrow down the cause.

jakirkham · 2016-08-09T03:58:05Z

If it would help alleviate some pressure, @Carreau, we could try applying a patch that fixes the issue to our ipython package. That is assuming the fix is known and available. Just let us know. 😄

Carreau · 2016-08-09T16:00:55Z

Ok, I had a deeper look and now I'm confused. Looking at the travis error, I have no clue why.

The issue @ccordoba12 linked to have 2 issues. One with AttributeError: module 'pkg_resources' has no attribute 'iter_entry_points' which is usually resolved by upgrading setuptools. The other ImportError: cannot import name 'NoOpContext' which was fixed there: ipython/ipython#9765

jakirkham · 2016-08-09T16:03:16Z

Was referring to the latter issue. Though we are using the latest setuptools. Maybe switching to pip fixes this.

conda-forge-linter · 2016-08-11T18:25:30Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ipython-sql, recipes/xray-vision) and found it was in an excellent condition.

Carreau · 2016-08-11T19:41:28Z

Btw, I think it is failing because IPython has been spelled with a lower case i in a few places, while it is IPython

Carreau · 2016-08-11T19:41:56Z

Dang, the joking tags are removed by GitHUb.

jakirkham · 2016-08-11T19:46:38Z

Must be GitHub's way of saying no more joking around. 😜

sodre · 2016-08-13T01:47:13Z

alright, it looks like the only issue left is with pygments for python 3.5, IPython 5 and win[64,32].
I will try with IPython 4 and see if it works for that platform.

conda-forge-linter · 2016-08-13T01:58:13Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ipython-sql) and found it was in an excellent condition.

- Win and Py35 require IPython<5

sodre · 2016-08-13T03:05:05Z

@jakirkham, It looks like the package is now ready to go.
What is the next step from my side?

jakirkham · 2016-08-24T02:21:50Z

recipes/ipython-sql/meta.yaml

+    - sql
+
+about:
+  home: pypi.python.org/pypi/ipython-sql


Might change to https://pypi.python.org/pypi/ipython-sql

jakirkham · 2016-08-24T02:27:28Z

recipes/ipython-sql/meta.yaml

+
+about:
+  home: https://pypi.python.org/pypi/ipython-sql
+  license: MIT


Ideally we would include the license file. However, they don't provide one. 😞

Have raised issue ( catherinedevlin/ipython-sql#58 ) to track this. Could we please add a comment here to add the license_file once they have provided one?

We need to add the MIT license file when catherinedevlin/ipython-sql#58 closes.

jakirkham · 2016-08-24T03:19:54Z

Thanks everyone for your help getting this one worked out. Thanks @sodre for contributing it.

jakirkham · 2016-08-24T03:20:43Z

Soon you should get an email that invites you to join conda-forge, @sodre. Once accepted you will be added to a team with the same name as this recipe. Those will give you permissions on the feedstock (repo) for this recipe.

Make sure when proposing any change that you go through the typical GitHub workflow of forking the feedstock and making changes in your fork that you PR back. Once merged CIs will build and deploy any changes you make. Please let us know if you have any questions and welcome to conda-forge.

sodre · 2016-08-24T03:22:11Z

Thanks! I will keep an eye out for the License fix.

Best,
Patrick

On Aug 23, 2016, at 11:20 PM, jakirkham notifications@github.com wrote:

Soon you should get an email that invites you to join conda-forge, @sodre https://github.com/sodre. Once accepted you will be added to a team with the same name as this recipe. Those will give you permissions on the feedstock (repo) for this recipe.

Make sure when proposing any change that you go through the typical GitHub workflow of forking the feedstock and making changes in your fork that you PR back. Once merged CIs will build and deploy any changes you make. Please let us know if you have any questions and welcome to conda-forge.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #1192 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AA_rVbTquKySrA5zY7A31G66ewXaHTvZks5qi7iLgaJpZM4JeWBH.

jakirkham reviewed Aug 6, 2016
View reviewed changes

sodre force-pushed the master branch from 98de9a8 to 7a95f89 Compare August 6, 2016 22:36

jakirkham reviewed Aug 6, 2016
View reviewed changes

sodre force-pushed the master branch 2 times, most recently from 76043b7 to 7cb8d10 Compare August 6, 2016 22:42

jakirkham reviewed Aug 8, 2016
View reviewed changes

sodre force-pushed the master branch from 20689ce to 76041b9 Compare August 11, 2016 18:25

sodre changed the title ~~Add iPython-SQL to conda-forge~~ Add IPython-SQL to conda-forge Aug 11, 2016

sodre force-pushed the master branch from 76041b9 to 974e4f0 Compare August 13, 2016 01:58

Add IPython-SQL to conda-forge

22666e4

- Win and Py35 require IPython<5

sodre force-pushed the master branch from c8ab1fd to 22666e4 Compare August 13, 2016 02:35

jakirkham reviewed Aug 24, 2016
View reviewed changes

Change home page to pypi

f940f5d

jakirkham reviewed Aug 24, 2016
View reviewed changes

Add reminder for license_file

1ae30bd

We need to add the MIT license file when catherinedevlin/ipython-sql#58 closes.

jakirkham merged commit d7822d1 into conda-forge:master Aug 24, 2016

Add IPython-SQL to conda-forge #1192

Add IPython-SQL to conda-forge #1192

Conversation

sodre commented Aug 6, 2016

conda-forge-linter commented Aug 6, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakirkham commented Aug 6, 2016

conda-forge-linter commented Aug 6, 2016

msarahan commented Aug 6, 2016

jakirkham commented Aug 6, 2016

sodre commented Aug 6, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conda-forge-linter commented Aug 6, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conda-forge-linter commented Aug 6, 2016

conda-forge-linter commented Aug 6, 2016

Choose a reason for hiding this comment

jakirkham commented Aug 8, 2016

jakirkham commented Aug 8, 2016

jakirkham commented Aug 8, 2016

jakirkham commented Aug 8, 2016

jakirkham commented Aug 8, 2016

ccordoba12 commented Aug 8, 2016

jakirkham commented Aug 8, 2016

Carreau commented Aug 8, 2016

jakirkham commented Aug 8, 2016

jakirkham commented Aug 9, 2016

Carreau commented Aug 9, 2016

jakirkham commented Aug 9, 2016

conda-forge-linter commented Aug 11, 2016

Carreau commented Aug 11, 2016 • edited

Carreau commented Aug 11, 2016

jakirkham commented Aug 11, 2016

sodre commented Aug 13, 2016

conda-forge-linter commented Aug 13, 2016

sodre commented Aug 13, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakirkham commented Aug 24, 2016

jakirkham commented Aug 24, 2016

sodre commented Aug 24, 2016

Carreau commented Aug 11, 2016 •

edited

sodre commented Aug 13, 2016 •

edited