Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion failing #6659

Closed
jakirkham opened this issue Sep 11, 2018 · 14 comments
Closed

Conversion failing #6659

jakirkham opened this issue Sep 11, 2018 · 14 comments
Labels

Comments

@jakirkham
Copy link
Member

@jakirkham jakirkham commented Sep 11, 2018

Looks like conversion started failing yesterday and has not been working since. Linking to the first log below.

cc @conda-forge/core @conda-forge/staged-recipes

ref: https://travis-ci.org/conda-forge/staged-recipes/builds/426812270

@scopatz
Copy link
Member

@scopatz scopatz commented Sep 12, 2018

It seems like a URL is getting filled out wrong:

requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://api.travis-ci.org/repo/conda-forge%2Fstaged-recipes/requests

Shouldn't the %2F be replaced by /

@jakirkham
Copy link
Member Author

@jakirkham jakirkham commented Sep 12, 2018

That actually ends up being correct usage, but agree it's a little counterintuitive.

ref: https://developer.travis-ci.com/resource/repository#find

@jakirkham
Copy link
Member Author

@jakirkham jakirkham commented Sep 12, 2018

Am starting to wonder if this may be related to the Travis CI GitHub App issue ( conda-forge/conda-forge.github.io#644 ).

Edit: ...or (at the bare minimum) if making that switch would fix it.

@mcflugen
Copy link
Contributor

@mcflugen mcflugen commented Sep 13, 2018

@jakirkham I notice that after new recipes are merged, although a *-feedstock repository is created, the feedstock repository is not populated.

For example see:

Is this the same problem that you're describing here? If so, and #644 is the source of the problem, is this something that individual feedstock maintainers can fix on a repository-by-repository basis or does it need to be done organization-wide? I would really love to get this working again!

@jakirkham
Copy link
Member Author

@jakirkham jakirkham commented Sep 13, 2018

Yes, this is the same issue, @mcflugen.

I'm not sure if issue ( conda-forge/conda-forge.github.io#644 ) is the cause, but it may be a way to solve this problem. It is also something we need to solve by the end of the month (ideally sooner). So it may be the best path forward.

Well issue ( conda-forge/conda-forge.github.io#644 ) involves making a fix to conda-smithy. Anyone that has time is welcome to start a PR over there. Have not looked deeply into the specific changes required, but they would need to happen in this file. Am fuzzy on the API needed. So this likely requires inspecting what Travis CI's migration tool is doing and using the same web API from there.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Sep 20, 2018

Looks like this may be fixed? I noticed that several repos were created with files now.

@mcflugen
Copy link
Contributor

@mcflugen mcflugen commented Sep 20, 2018

Yep. This appears to be working for me now! 💥💥💥

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Sep 20, 2018

It's a bit confusing, actually, since the file noted above (https://github.com/conda-forge/conda-smithy/blob/master/conda_smithy/ci_register.py) hasn't been touched.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Sep 20, 2018

@mcflugen
Copy link
Contributor

@mcflugen mcflugen commented Sep 20, 2018

Well, things started to work after I got an alert saying that a conda-forge organization owner approved the Travis CI application to access private data in conda-forge so I'm guessing it was a permissions problem (which may be related to conda-forge/conda-forge.github.io#644).

@scopatz
Copy link
Member

@scopatz scopatz commented Sep 20, 2018

Interesting - GitHub Services were deprecated, which Travis used to rely on. They then had to migrate (to webhooks?) and so I ma guessing that we got held up because of that.

@scopatz
Copy link
Member

@scopatz scopatz commented Sep 20, 2018

Glad it is working now!

@scopatz scopatz closed this Sep 20, 2018
@jakirkham
Copy link
Member Author

@jakirkham jakirkham commented Sep 20, 2018

The new feedstocks seem to still be using the old, deprecated GitHub Services. So not sure.

That said, the Travis CI GitHub App is enabled for the org, which the new feedstocks have been registered with as well. Would be interesting to know which step triggers the addition to the Travis CI GitHub App. In any event, that is most likely what fixed it.

Now it's just a matter of migrating the existing feedstocks to the Travis CI GitHub App as well.

@isuruf
Copy link
Member

@isuruf isuruf commented Sep 20, 2018

Yes, it's still using the old services for new feedstocks. I was playing with permissions today morning. Not sure what fixed it. 😄

@fedarko fedarko mentioned this issue Apr 3, 2020
8 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.