Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sccache recipe #10514

Merged
merged 1 commit into from Jan 4, 2020
Merged

add sccache recipe #10514

merged 1 commit into from Jan 4, 2020

Conversation

@luizirber
Copy link
Contributor

luizirber commented Jan 1, 2020

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there
@conda-forge-linter

This comment has been minimized.

Copy link

conda-forge-linter commented Jan 1, 2020

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sccache) and found some lint.

Here's what I've got...

For recipes/sccache:

  • The summary item is expected in the about section.
@conda-forge-linter

This comment has been minimized.

Copy link

conda-forge-linter commented Jan 1, 2020

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sccache) and found it was in an excellent condition.

- rust
- {{ compiler('c') }} # [not win]
- {{ compiler('m2w64_c') }} # [win]
- openssl

This comment has been minimized.

Copy link
@marcelotrevisani

marcelotrevisani Jan 1, 2020

Member

openssl should not be here, could you please delete it?

Suggested change
- openssl

This comment has been minimized.

Copy link
@marcelotrevisani

marcelotrevisani Jan 1, 2020

Member

I think rust should be in host and run requirements, am I right?

This comment has been minimized.

Copy link
@luizirber

luizirber Jan 1, 2020

Author Contributor

You don't need rust to run, it generates a static binary (but linking to openssl dinamically). Is build requirements only for {{ compiler }} deps?

about:
home: https://github.com/mozilla/sccache
summary: 'sccache is ccache with cloud storage'
license: Apache 2.0

This comment has been minimized.

Copy link
@marcelotrevisani

marcelotrevisani Jan 1, 2020

Member
Suggested change
license: Apache 2.0
license: Apache-2.0
@luizirber

This comment has been minimized.

Copy link
Contributor Author

luizirber commented Jan 1, 2020

thanks @marcelotrevisani! Seems like I'm overlinking libresolv.9 on macOS, pointers on how to fix it?

@luizirber

This comment has been minimized.

Copy link
Contributor Author

luizirber commented Jan 1, 2020

should I whitelist libresolv.9.dylib, like the cyrus-sasl feedstock does?

@luizirber luizirber force-pushed the luizirber:sccache branch from 70f8178 to aa24403 Jan 2, 2020
@conda-forge-linter

This comment has been minimized.

Copy link

conda-forge-linter commented Jan 2, 2020

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sccache) and found some lint.

Here's what I've got...

For recipes/sccache:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [28]
@luizirber luizirber force-pushed the luizirber:sccache branch from aa24403 to a4060b4 Jan 2, 2020
@conda-forge-linter

This comment has been minimized.

Copy link

conda-forge-linter commented Jan 2, 2020

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sccache) and found it was in an excellent condition.

@luizirber luizirber force-pushed the luizirber:sccache branch from a4060b4 to 41a8bc7 Jan 2, 2020
build:
- rust
- {{ compiler('c') }} # [not win]
- {{ compiler('m2w64_c') }} # [win]

This comment has been minimized.

Copy link
@luizirber

luizirber Jan 2, 2020

Author Contributor

what is the proper way to choose a compiler for windows? I used the ripgrep feedstock as example, and it was using this one.

This comment has been minimized.

Copy link
@mariusvniekerk

mariusvniekerk Jan 2, 2020

Contributor

This looks fine. If your package can build with msvc instead of the gnu ones you can just use compiler('c')

This comment has been minimized.

Copy link
@luizirber

luizirber Jan 2, 2020

Author Contributor

I tried with compiler('c'), but then it couldn't link openssl. Reverting to compiler('m2w64_c') for now.

@luizirber luizirber requested a review from marcelotrevisani Jan 2, 2020
@luizirber

This comment has been minimized.

Copy link
Contributor Author

luizirber commented Jan 2, 2020

Ready for review @conda-forge/staged-recipes

@luizirber luizirber force-pushed the luizirber:sccache branch 2 times, most recently from 0302328 to e467d9f Jan 2, 2020
@chrisburr chrisburr merged commit 41eb085 into conda-forge:master Jan 4, 2020
6 checks passed
6 checks passed
conda-forge-linter All recipes are excellent.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
staged-recipes Build #20200102.5 succeeded
Details
staged-recipes (linux_64 linux) linux_64 linux succeeded
Details
staged-recipes (osx_64 osx) osx_64 osx succeeded
Details
staged-recipes (win_64 win) win_64 win succeeded
Details
@luizirber luizirber deleted the luizirber:sccache branch Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.