Skip to content

Add matrix_client#10558

Merged
chrisburr merged 4 commits into
conda-forge:masterfrom
setu4993:matrix
Jan 9, 2020
Merged

Add matrix_client#10558
chrisburr merged 4 commits into
conda-forge:masterfrom
setu4993:matrix

Conversation

@setu4993
Copy link
Copy Markdown
Member

@setu4993 setu4993 commented Jan 9, 2020

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/matrix_client) and found some lint.

Here's what I've got...

For recipes/matrix_client:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [14]
  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/matrix_client) and found it was in an excellent condition.

@setu4993
Copy link
Copy Markdown
Member Author

setu4993 commented Jan 9, 2020

@conda-forge/staged-recipes, @conda-forge/help-python: This PR is ready for review.

Comment thread recipes/matrix_client/meta.yaml Outdated
Comment thread recipes/matrix_client/meta.yaml Outdated
@setu4993
Copy link
Copy Markdown
Member Author

setu4993 commented Jan 9, 2020

@chrisburr : Thanks for reviewing quickly!

@setu4993 setu4993 requested a review from chrisburr January 9, 2020 15:11
Copy link
Copy Markdown
Member

@chrisburr chrisburr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed these two when I first reviewed.

Comment thread recipes/matrix_client/meta.yaml Outdated
Comment thread recipes/matrix_client/meta.yaml Outdated
@setu4993
Copy link
Copy Markdown
Member Author

setu4993 commented Jan 9, 2020

@chrisburr : Thanks for reviewing again, I have now removed the unused dependencies from host and test.

@setu4993 setu4993 requested a review from chrisburr January 9, 2020 19:22
@chrisburr chrisburr merged commit 735c939 into conda-forge:master Jan 9, 2020
@setu4993 setu4993 deleted the matrix branch April 6, 2020 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants