Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deepchem #10818

Merged
merged 7 commits into from Feb 13, 2020
Merged

Add deepchem #10818

merged 7 commits into from Feb 13, 2020

Conversation

@simonbray
Copy link
Member

simonbray commented Feb 10, 2020

Moved from #10177.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there
hadim and others added 3 commits Nov 16, 2019
@conda-forge-linter

This comment has been minimized.

Copy link

conda-forge-linter commented Feb 10, 2020

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/deepchem) and found some lint.

Here's what I've got...

For recipes/deepchem:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.
@simonbray simonbray mentioned this pull request Feb 10, 2020
7 of 7 tasks complete
@conda-forge-linter

This comment has been minimized.

Copy link

conda-forge-linter commented Feb 10, 2020

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/deepchem) and found some lint.

Here's what I've got...

For recipes/deepchem:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.
@conda-forge-linter

This comment has been minimized.

Copy link

conda-forge-linter commented Feb 10, 2020

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/deepchem) and found it was in an excellent condition.

build:
number: 0
script: "PBR_VERSION=${PKG_VERSION} && export PBR_VERSION && {{ PYTHON }} -m pip install . --no-deps --ignore-installed -vv"
skip: True # [win or py==27]

This comment has been minimized.

Copy link
@scopatz

scopatz Feb 12, 2020

Member

Can this be noarch Python?

This comment has been minimized.

This comment has been minimized.

Copy link
@scopatz

scopatz Feb 13, 2020

Member

noarch only needs to build on linux, so you shouldn't worry about the windows failures

This comment has been minimized.

Copy link
@simonbray

simonbray Feb 13, 2020

Author Member

@scopatz, have updated and the linux build is passing.

@scopatz scopatz merged commit 5d1a2de into conda-forge:master Feb 13, 2020
3 of 6 checks passed
3 of 6 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
staged-recipes Build #20200212.63 failed
Details
staged-recipes (win_64 win) win_64 win failed
Details
conda-forge-linter All recipes are excellent.
Details
staged-recipes (linux_64 linux) linux_64 linux succeeded
Details
staged-recipes (osx_64 osx) osx_64 osx succeeded
Details
@scopatz

This comment has been minimized.

Copy link
Member

scopatz commented Feb 13, 2020

Thanks!

@rbharath

This comment has been minimized.

Copy link

rbharath commented Feb 19, 2020

@simonbray Thanks for putting this together! This is really exciting to see deepchem added to the condo-forge build :). (Sorry for the slow response; been offline for the last couple weeks). Feel free to tag me if there are any DeepChem issues that pop up in the future

@simonbray simonbray deleted the simonbray:deepchem2 branch Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.