-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding zipline dependencies (trading-calendars, python-interface, iso4217) #12553
Adding zipline dependencies (trading-calendars, python-interface, iso4217) #12553
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I'm okay being a maintainer. |
I am okay being a maintainer. |
1 similar comment
I am okay being a maintainer. |
Ok fine I'm willing to be a maintainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even thought staged-recipes
correctly handles multiple inter-dependent recipes in a single PR, once this is merged, you are likely to see build issues when not all of the dependent packages have hit the conda-forge CDN yet:
It might be worth it to split the zipline
recipe off into its own PR to avoid this.
recipes/zipline/LICENSE
Outdated
@@ -0,0 +1,202 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This license file is already included in the source distribution, so you can remove it here.
recipes/trading-calendars/LICENSE
Outdated
@@ -0,0 +1,202 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This license file is already included in the source distribution, so please remove it here
home: https://github.com/ssanderson/python-interface | ||
license: Apache-2.0 | ||
license_family: APACHE | ||
license_file: LICENSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are manually packaging the license file, please add the following comment as a reminder to check whether the license file is included in future releases in the source distribution:
...
license_family: APACHE
# License file manually packaged. See https://github.com/ssanderson/python-interface/pull/40
license_file: LICENSE
I opened a PR at ssanderson/python-interface#40 to try to deal with this
Thanks @synapticarbors . I'll make those license changes and split out zipline. Will open another PR for that... |
I also approve being listed as a maintainer. |
7a699c8
to
ff4c9d3
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@rsheftel Are you ok being added here as a maintainer of trading-calendars? |
Yes |
ff4c9d3
to
e0f25f2
Compare
@synapticarbors Updated as you suggested (I believe). The zipline-only PR is #12569, and we have ok's from the listed maintainers. Thanks so much. |
@richafrank -- One quick thing that I apologize for not spotting previously. For |
Oh, that's a great call. So much nicer to have the noarch builds. I just updated them as you suggested. |
Includes zipline, trading-calendars, python-interface, and iso4217
Checklist
If static libraries are linked in, the license of the static library is packaged.url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details)