Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding zipline dependencies (trading-calendars, python-interface, iso4217) #12553

Merged
merged 4 commits into from
Sep 6, 2020

Conversation

richafrank
Copy link
Contributor

@richafrank richafrank commented Sep 3, 2020

Includes zipline, trading-calendars, python-interface, and iso4217

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/iso4217, recipes/python-interface, recipes/trading-calendars, recipes/zipline) and found it was in an excellent condition.

@gerrymanoim
Copy link

I'm okay being a maintainer.

@llllllllll
Copy link

I am okay being a maintainer.

1 similar comment
@jmccorriston
Copy link

I am okay being a maintainer.

@jbredeche
Copy link

Ok fine I'm willing to be a maintainer

Copy link
Member

@synapticarbors synapticarbors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even thought staged-recipes correctly handles multiple inter-dependent recipes in a single PR, once this is merged, you are likely to see build issues when not all of the dependent packages have hit the conda-forge CDN yet:

https://conda-forge.org/docs/maintainer/adding_pkgs.html?highlight=multiple#adding-multiple-packages-at-once

It might be worth it to split the zipline recipe off into its own PR to avoid this.

@@ -0,0 +1,202 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This license file is already included in the source distribution, so you can remove it here.

@@ -0,0 +1,202 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This license file is already included in the source distribution, so please remove it here

home: https://github.com/ssanderson/python-interface
license: Apache-2.0
license_family: APACHE
license_file: LICENSE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are manually packaging the license file, please add the following comment as a reminder to check whether the license file is included in future releases in the source distribution:

...
license_family: APACHE
# License file manually packaged. See https://github.com/ssanderson/python-interface/pull/40
license_file: LICENSE

I opened a PR at ssanderson/python-interface#40 to try to deal with this

@richafrank
Copy link
Contributor Author

Thanks @synapticarbors .

I'll make those license changes and split out zipline. Will open another PR for that...

@jdricklefs
Copy link

I also approve being listed as a maintainer.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/iso4217, recipes/python-interface, recipes/trading-calendars) and found it was in an excellent condition.

@richafrank
Copy link
Contributor Author

@rsheftel Are you ok being added here as a maintainer of trading-calendars?

@richafrank richafrank changed the title Adding zipline and its dependencies Adding zipline dependencies (trading-calendars, python-interface, iso4217) Sep 4, 2020
@rsheftel
Copy link

rsheftel commented Sep 4, 2020

Yes

@richafrank richafrank mentioned this pull request Sep 4, 2020
8 tasks
@richafrank
Copy link
Contributor Author

@synapticarbors Updated as you suggested (I believe). The zipline-only PR is #12569, and we have ok's from the listed maintainers. Thanks so much.

@synapticarbors
Copy link
Member

@richafrank -- One quick thing that I apologize for not spotting previously. For iso4217 and python-interface, conda-forge does not build any packages for py < 3.6 unless you specifically need python 2.7 support (See: https://conda-forge.org/docs/maintainer/infrastructure.html#conda-forge-admin-please-add-python-2-7). Therefore, I think we could drop all of the py2k and py<34 selectors, and make those two packages noarch: python and then just changes python to python >=3.6 under host and run.

@richafrank
Copy link
Contributor Author

Oh, that's a great call. So much nicer to have the noarch builds. I just updated them as you suggested.

@synapticarbors synapticarbors merged commit 79d1546 into conda-forge:master Sep 6, 2020
@richafrank richafrank deleted the zipline-and-deps branch September 7, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

9 participants