Add scikit-build #1989

isuruf · Nov 23, 2016

@jcfr, @msarahan, @scopatz let me know if you are interested in maintaining this.

@jcfr, can you take a look at the build and run requirements and see if any package is missing?

conda-forge-linter · Nov 23, 2016

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/scikit-build) and found it was in an excellent condition.

jcfr · Nov 23, 2016

jcfr reviewed Nov 23, 2016

View changes

jcfr · Nov 23, 2016

recipes/scikit-build/meta.yaml

+
+test:
+  imports:
+    - skbuild


Would it make sense to run the full test suite ?

Yes, how do I run the full test suite?

pytest or python setup.py test will work

scopatz · Nov 23, 2016

Sure, feel free to add me.

jcfr · Nov 23, 2016

@isuruf Thanks for contributing the recipe. You rock !

build and run requirements and see if any package is missing
Looks good

test

I wonder if it would make sense to run the full test suite

interested in maintaining this

I would be happy to learn. My experience with conda recipe is limited.

In the mean time, your help is very much appreciated 😄

Cc: @thewtex

isuruf · Nov 23, 2016

I'm getting test failures. See build log here, https://circleci.com/gh/isuruf/staged-recipes/104

Most tests fail because cmake can't find FindPythonExtensions.cmake.
Two other test failures are there. One is no fortran compiler (It's better if we can skip this test). Second one is that the current working directory is not scikit-build but scikit-build-0.4.0. This seems like a weird requirement to run the test suite.

msarahan · Nov 23, 2016

Can add me if you want. I should be able to help more soon.

isuruf · Nov 23, 2016

I've disabled the 3 tests that are failing (2 that check the directory name and the one that checks for the fortran compiler.)

Ready for a final review now

scopatz · Nov 23, 2016

scopatz reviewed Nov 23, 2016

View changes

scopatz · Nov 23, 2016

recipes/scikit-build/meta.yaml

+  script:
+    - python setup.py install --single-version-externally-managed --record record.txt
+    # Tests are skipped for now.
+    - py.test -k "not (test_push_dir or test_fortran_compiler)"


This should be in the test block (not the build block) and should be under the "commands" block (which lives at the same level as "imports")

Tests are not installed, so this has to be done in build phase.

You can cd to the source directory in the test phase. This is what many recipes do.

Can you give an example recipe that does this?

This is why we need docs, example at https://github.com/conda-forge/cyclus-feedstock/blob/master/recipe/run_test.sh#L3

@scopatz, added this, https://github.com/conda-forge/staged-recipes/wiki/Common-issues

scopatz · Nov 23, 2016

scopatz reviewed Nov 23, 2016

View changes

scopatz · Nov 23, 2016

recipes/scikit-build/meta.yaml

+    - python
+    - setuptools
+    - wheel
+    # Following dependencies are for testing needed in build phase


Test dependencies should be in the "test" section in the "requires" section.

scopatz · Nov 23, 2016

@isuruf - please see other recipes and the conda build docs for more info on testing. Or feel free to ask questions

msarahan · Nov 23, 2016

Better way with conda build 2 is to use the test/source_files entry to
ensure that source files are present at test time.

On Nov 23, 2016 2:07 PM, "Isuru Fernando" notifications@github.com wrote:

@isuruf commented on this pull request.

In recipes/scikit-build/meta.yaml
#1989:

+package:

name: {{ name|lower }}

version: {{ version }}

+source:

fn: {{ name }}-{{ version }}.tar.gz

url: https://github.com/scikit-build/scikit-build/archive/{{ version }}.tar.gz

sha256: {{ sha256 }}

+build:

number: 0

script:

python setup.py install --single-version-externally-managed --record record.txt

Tests are skipped for now.

py.test -k "not (test_push_dir or test_fortran_compiler)"

@scopatz https://github.com/scopatz, added this,
https://github.com/conda-forge/staged-recipes/wiki/Common-issues

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1989, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AACV-Y2LwUsoVjkLwNDdGqPzRqm81EAxks5rBJ0PgaJpZM4K6jBt
.

jcfr · Nov 23, 2016

@isuruf Thanks for your persistence 👍 I will work on addressing your comments to improve scikit-build testing asap.

isuruf · Nov 24, 2016

isuruf reviewed Nov 24, 2016

View changes

isuruf · Nov 24, 2016

recipes/scikit-build/python27-x64.patch

+         # string IDs seem to be just the vs_base.
+ 
+         self.default_generators.insert(0, vs_base)
+        self.default_generators.insert(1, "NMake Makefiles")


@jcfr, I've added this patch because of this issue, conda/conda-build#1327

scikit-build test-suite doesn't like the fact that Visual Studio 9 2008 Win64 fails, but NMake doesn't.

> assert(get_best_generator() == generator) E assert 'NMake Makefiles' == 'Visual Studio 9 2008 Win64'

isuruf · Nov 24, 2016

@msarahan, conda-forge is using conda-build 2.0.10, but test/source_files is not supported
See this build log https://circleci.com/gh/isuruf/staged-recipes/109

isuruf · Nov 24, 2016

sorry about the confusion, it's using 1.2.14

isuruf · Nov 24, 2016

isuruf reviewed Nov 24, 2016

View changes

isuruf · Nov 24, 2016

recipes/scikit-build/python27-x64.patch

+         # string IDs seem to be just the vs_base.
+ 
+         self.default_generators.insert(0, vs_base)
+        self.default_generators.insert(0, "NMake Makefiles")


I've changed this to make NMake Makefiles the default for win and py27 and x86_64. I see that in scikit-ci-addons, this is fixed in appveyor by running a script that needs elevated permissions, which a user might not have. I think there is no harm in trying NMake first before trying a Visual Studio project. Any objections or other suggestions?

jcfr · Nov 24, 2016

jcfr reviewed Nov 24, 2016

View changes

jcfr · Nov 24, 2016

recipes/scikit-build/python27-x64.patch

@@ -0,0 +1,13 @@
+MSVC 9 x64 is broken on appveyor. Use NMake there.


It could easily be fixed using the patch_vs2008 add-on provided by scikit-ci-addons

See http://scikit-ci-addons.readthedocs.io/en/latest/addons.html#patch-vs2008-py

Yes, there is also a conda package that does this, https://github.com/conda-forge/vs2008_express_vc_python_patch-feedstock

But this is discouraged because this requires admin privileges. cc @jakirkham

I created an issue in scikit-build to better support Microsoft Visual C++ Compiler for Python 2.7. See scikit-build/scikit-build#216 for more details.

requires admin privileges.

I think in practice it is reasonable to assume developers have admin privileges on their workstation.

Similarly to the installation of recent Visual Studio (e.g VS2015 for Python3.5) already requiring admin privileges, expecting developer to patch their install of Visual Studio 2008 express seems fair.

That said, installing arbitrary patches to modify an official installation could be a problem here and supporting " Microsoft Visual C++ Compiler for Python 2.7" would be a more sane alternative.

Yeah, my thinking is we will install those patches in the CI beforehand as they are valuable occasionally. However, trying to use Microsoft Visual C++ Compiler for Python 2.7 is preferable.

thewtex · Nov 25, 2016

@isuruf Thanks for driving this forward. This is excellent!

isuruf · Nov 26, 2016

I've reverted the last commit and will use a better patch coming out of scikit-build/scikit-build#216.
That means for win and py27 and x86_64, NMake is used after checking MSVC. Conda should be activating NMake with the correct parameters and therefore no more checks are needed to make sure the NMake environment matches that of the python environment

scopatz · Nov 27, 2016

This seems reasonable to me. Any objections to merging?

jakirkham · Nov 28, 2016

No objections from me. Looks good.

scopatz · Nov 28, 2016

Thanks All!

jcfr · Nov 28, 2016

Thanks a lot 👍

jakirkham · Nov 28, 2016

jakirkham reviewed Nov 28, 2016

View changes

jakirkham · Nov 28, 2016

recipes/scikit-build/meta.yaml

+  commands:
+    - cd ${SRC_DIR} && py.test -k "not (test_push_dir or test_fortran_compiler)"    # [unix]
+    - cd %SRC_DIR% && py.test -k "not (test_push_dir or test_fortran_compiler)"     # [win and not (py27 and x86_64)]
+    - cd %SRC_DIR% && py.test -k "not (test_push_dir or test_fortran_compiler or test_generator_selection or test_hello_builds_with_generator)"     # [win and py27 and x86_64]


Something to keep in mind is we had problems with these x86_64 selectors recently in our maintenance scripts. ( conda-forge/dmd-feedstock#2 ) We may need to change the feedstock not to use these.

Add scikit-build

Verified

This commit was signed with a verified signature.

isuruf Isuru Fernando

GPG key ID: EEB0FC153CA8B9A4 Learn about signing commits

Loading status checks…

424dc2e

wheel is runtime requirement

Verified

This commit was signed with a verified signature.

isuruf Isuru Fernando

GPG key ID: EEB0FC153CA8B9A4 Learn about signing commits

Loading status checks…

5e6a5fd

jcfr referenced this pull request Nov 23, 2016
Closed
Conda package? #213

isuruf added some commits Nov 23, 2016

Skip failing tests for now

74f055e

Add msarahan to maintainers

Loading status checks…

daf7ef9

Add cython for testing

Loading status checks…

54af0f2

jcfr referenced this pull request Nov 23, 2016
Closed
C matrices #158

jcfr referenced this pull request Nov 24, 2016
Merged
tests: Improve "push_dir" tests to not rely on build directory name #215

isuruf added some commits Nov 24, 2016

Use test/source_files

459c55a

Patch for python27-x64

Loading status checks…

7450fb5

test/source_files is not in conda-build < 2

Loading status checks…

71fe419

pytest.ini needs pytest-cov

Loading status checks…

400d61a

isuruf added some commits Nov 24, 2016

stop failing builds for win and py27 and x86_64

Loading status checks…

9691f78

Make NMake the default generator for [win and py27 and x86_64]

Loading status checks…

4a0fdd6

Revert "Make NMake the default generator for [win and py27 and x86_64]"
This reverts commit 4a0fdd6.

Loading status checks…

e3a6550

conda-forge/staged-recipes

Join GitHub today

Add scikit-build #1989

Conversation

isuruf commented Nov 23, 2016

This comment has been minimized.

conda-forge-linter commented Nov 23, 2016

jcfr reviewed Nov 23, 2016 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

scopatz commented Nov 23, 2016

This comment has been minimized.

jcfr commented Nov 23, 2016

jcfr referenced this pull request Nov 23, 2016

isuruf added some commits Nov 23, 2016

This comment has been minimized.

isuruf commented Nov 23, 2016

isuruf added some commits Nov 23, 2016

This comment has been minimized.

msarahan commented on 27a5cbb Nov 23, 2016

isuruf added some commits Nov 23, 2016

This comment has been minimized.

isuruf commented Nov 23, 2016

scopatz reviewed Nov 23, 2016 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

scopatz reviewed Nov 23, 2016 View changes

This comment has been minimized.

This comment has been minimized.

scopatz commented Nov 23, 2016

This comment has been minimized.

msarahan commented Nov 23, 2016

@isuruf commented on this pull request.

Tests are skipped for now.

jcfr referenced this pull request Nov 23, 2016

This comment has been minimized.

jcfr commented Nov 23, 2016

jcfr added a commit to scikit-build/scikit-build that referenced this pull request Nov 24, 2016

jcfr referenced this pull request Nov 24, 2016

isuruf added some commits Nov 24, 2016

isuruf reviewed Nov 24, 2016 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

isuruf commented Nov 24, 2016

This comment has been minimized.

isuruf commented Nov 24, 2016

isuruf added some commits Nov 24, 2016

isuruf reviewed Nov 24, 2016 View changes

This comment has been minimized.

isuruf Nov 24, 2016 • edited

jcfr reviewed Nov 24, 2016 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jcfr Nov 24, 2016 • edited

This comment has been minimized.

This comment has been minimized.

thewtex commented Nov 25, 2016

This comment has been minimized.

isuruf commented Nov 26, 2016

This comment has been minimized.

scopatz commented Nov 27, 2016

This comment has been minimized.

jakirkham commented Nov 28, 2016

Hide details View details scopatz merged commit c77b9eb into conda-forge:master Nov 28, 2016 4 checks passed

4 checks passed

This comment has been minimized.

scopatz commented Nov 28, 2016

This comment has been minimized.

jcfr commented Nov 28, 2016

jakirkham reviewed Nov 28, 2016 View changes

This comment has been minimized.

jcfr reviewed Nov 23, 2016

View changes

msarahan commented on `27a5cbb` Nov 23, 2016

scopatz reviewed Nov 23, 2016

View changes

scopatz reviewed Nov 23, 2016

View changes

isuruf reviewed Nov 24, 2016

View changes

isuruf reviewed Nov 24, 2016

View changes

isuruf Nov 24, 2016 •

edited

jcfr reviewed Nov 24, 2016

View changes

jcfr Nov 24, 2016 •

edited

scopatz merged commit `c77b9eb` into conda-forge:master Nov 28, 2016
4 checks passed

jakirkham reviewed Nov 28, 2016

View changes