New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extending git-annex to MacOS. #4157

Closed
wants to merge 44 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@notestaff
Contributor

notestaff commented Oct 11, 2017

There is an already-working PR #4141 adding git-annex for Linux. This branch tries to extend that to MacOS.

notestaff added some commits Oct 9, 2017

@conda-forge-linter

This comment has been minimized.

Show comment
Hide comment
@conda-forge-linter

conda-forge-linter Oct 11, 2017

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/git-annex, recipes/popt, recipes/rsync) and found it was in an excellent condition.

conda-forge-linter commented Oct 11, 2017

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/git-annex, recipes/popt, recipes/rsync) and found it was in an excellent condition.

@conda-forge-linter

This comment has been minimized.

Show comment
Hide comment
@conda-forge-linter

conda-forge-linter Oct 11, 2017

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/flasgger) and found it was in an excellent condition.

conda-forge-linter commented Oct 11, 2017

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/flasgger) and found it was in an excellent condition.

@conda-forge-linter

This comment has been minimized.

Show comment
Hide comment
@conda-forge-linter

conda-forge-linter Oct 11, 2017

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/git-annex, recipes/popt, recipes/rsync) and found some lint.

Here's what I've got...

For recipes/git-annex:

  • The recipe must have some tests.

conda-forge-linter commented Oct 11, 2017

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/git-annex, recipes/popt, recipes/rsync) and found some lint.

Here's what I've got...

For recipes/git-annex:

  • The recipe must have some tests.
@conda-forge-linter

This comment has been minimized.

Show comment
Hide comment
@conda-forge-linter

conda-forge-linter Oct 12, 2017

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/git-annex, recipes/popt, recipes/rsync) and found it was in an excellent condition.

conda-forge-linter commented Oct 12, 2017

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/git-annex, recipes/popt, recipes/rsync) and found it was in an excellent condition.

@notestaff notestaff changed the title from work-in-progress on git-annex to extending git-annex to MacOS. Oct 12, 2017

@yarikoptic

This comment has been minimized.

Show comment
Hide comment
@yarikoptic

yarikoptic Oct 31, 2017

Contributor

@notestaff Please let me know if you need an assistance with this one. Thanks again for working on packaging git-annex

Contributor

yarikoptic commented Oct 31, 2017

@notestaff Please let me know if you need an assistance with this one. Thanks again for working on packaging git-annex

@notestaff

This comment has been minimized.

Show comment
Hide comment
@notestaff

notestaff Oct 31, 2017

Contributor

@yarikoptic assistance welcome. i'm mostly off-work till next week, but feel free to clone this branch and try to fix the MacOS build errors.

Contributor

notestaff commented Oct 31, 2017

@yarikoptic assistance welcome. i'm mostly off-work till next week, but feel free to clone this branch and try to fix the MacOS build errors.

@joeyh

This comment has been minimized.

Show comment
Hide comment
@joeyh

joeyh Nov 1, 2017

Re the iconv related problem in the CI build, this seems to be due to the wrong version of the iconv library being used by the linker, instead of the one bundled with the binary of ghc that stack has downloaded.

It may be that the build.sh's LIBRARY_PATH, LDFLAGS etc environment settings are causing this problem, if they drag in some other version of iconv.

joeyh commented Nov 1, 2017

Re the iconv related problem in the CI build, this seems to be due to the wrong version of the iconv library being used by the linker, instead of the one bundled with the binary of ghc that stack has downloaded.

It may be that the build.sh's LIBRARY_PATH, LDFLAGS etc environment settings are causing this problem, if they drag in some other version of iconv.

@notestaff notestaff closed this Dec 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment