Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plasmapy #4793

Open
wants to merge 21 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@SolarDrew
Copy link
Contributor

SolarDrew commented Jan 15, 2018

Recipe for plasmapy.

@conda-forge-linter

This comment has been minimized.

Copy link

conda-forge-linter commented Jan 15, 2018

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/plasmapy) and found some lint.

Here's what I've got...

For recipes/plasmapy:

  • Failed to even lint the recipe (might be a conda-smithy bug) 😢

build:
number: 0
script: python setup.py install --offline --no-git --single-version-externally-managed --record=record.txt

This comment has been minimized.

Copy link
@CJ-Wright

CJ-Wright Jan 15, 2018

Contributor

Do you need the --offline and --no-git?

This comment has been minimized.

Copy link
@SolarDrew

SolarDrew Jan 16, 2018

Author Contributor

I thought I did, but I'll try it without again and see if it builds.

This comment has been minimized.

Copy link
@SolarDrew

SolarDrew Jan 22, 2018

Author Contributor

Turns out I do need the --offline but not the --no-git, so I'll remove that.

@conda-forge-linter

This comment has been minimized.

Copy link

conda-forge-linter commented Jan 29, 2018

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/plasmapy) and found it was in an excellent condition.

- numpy
- scipy
- astropy
- coveralls

This comment has been minimized.

Copy link
@bgruening

bgruening Feb 4, 2018

Contributor

this is usually not a requirement of a package, isn't it?

This comment has been minimized.

Copy link
@SolarDrew

SolarDrew Feb 5, 2018

Author Contributor

No, you're right, I think I put that in to try and solve some problem and then forgot to take it out when it didn't work.

@SolarDrew

This comment has been minimized.

Copy link
Contributor Author

SolarDrew commented Mar 12, 2018

Hi @bgruening , @CJ-Wright , any further opinions on this?

build:
number: 0
script: python setup.py install --offline --single-version-externally-managed --record=record.txt
skip: True # [py2k]

This comment has been minimized.

Copy link
@CJ-Wright

CJ-Wright Mar 12, 2018

Contributor

Could you put the python version requirement into the deps and make this a noarch package? I'm assuming that this doesn't compile anything.

This comment has been minimized.

Copy link
@SolarDrew

SolarDrew May 3, 2018

Author Contributor

Not currently, no, so I've changed that. Thanks.


build:
number: 0
script: python setup.py install --offline --single-version-externally-managed --record=record.txt

This comment has been minimized.

Copy link
@CJ-Wright

CJ-Wright Mar 12, 2018

Contributor

Could you use pip for this? (See the cf docs)

This comment has been minimized.

Copy link
@SolarDrew

SolarDrew May 3, 2018

Author Contributor

I don't think so, because I need the --offline option, so I think I need to do it this way.

@conda-forge-linter

This comment has been minimized.

Copy link

conda-forge-linter commented May 3, 2018

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/plasmapy) and found some lint.

Here's what I've got...

For recipes/plasmapy:

build:
number: 0
script: python setup.py install --offline --single-version-externally-managed --record=record.txt
noarch: python

This comment has been minimized.

Copy link
@msarahan

msarahan Jul 15, 2018

Member

Has compiled extensions. Can't be noarch. I'll submit a commit with it changed.

@conda-forge-linter

This comment has been minimized.

Copy link

conda-forge-linter commented Jul 15, 2018

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/plasmapy) and found it was in an excellent condition.

@msarahan

This comment has been minimized.

Copy link
Member

msarahan commented Jul 15, 2018

This should be mostly what you need. The tests are failing with:

import: 'plasmapy'
Traceback (most recent call last):
  File "/Users/msarahan/miniconda3/conda-bld/plasmapy_1531675389232/test_tmp/run_test.py", line 2, in <module>
    import plasmapy
  File "/Users/msarahan/miniconda3/conda-bld/plasmapy_1531675389232/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.6/site-packages/plasmapy/__init__.py", line 28, in <module>
    from . import atomic
  File "/Users/msarahan/miniconda3/conda-bld/plasmapy_1531675389232/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.6/site-packages/plasmapy/atomic/__init__.py", line 8, in <module>
    from .particle_class import Particle
  File "/Users/msarahan/miniconda3/conda-bld/plasmapy_1531675389232/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.6/site-packages/plasmapy/atomic/particle_class.py", line 23, in <module>
    from .parsing import (
  File "/Users/msarahan/miniconda3/conda-bld/plasmapy_1531675389232/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.6/site-packages/plasmapy/atomic/parsing.py", line 3, in <module>
    import roman
ModuleNotFoundError: No module named 'roman'

I have no idea where "roman" is supposed to come from, but I think that's on your end.

@wtbarnes

This comment has been minimized.

Copy link

wtbarnes commented Jul 15, 2018

I've pinged @SolarDrew about this. I believe roman was recently added as a dependency so this should be an easy fix.

@wtbarnes wtbarnes referenced this pull request Aug 16, 2018

Open

Get onto Conda #93

@StanczakDominik

This comment has been minimized.

Copy link

StanczakDominik commented Aug 20, 2018

Hi! I'm currently looking into this in the interest of getting this finally done. I'm new to conda-forge, so let me ask a question here. If I understand things correctly, this part:

source:
fn: '{{ name }}-{{ version }}.{{ file_ext }}'
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.{{ file_ext }}
'{{ hash_type }}': '{{ hash_value }}'

seems to imply that what conda-forge does is take the specified (0.1.1 as of now) release from PyPI, then build, compile and in general work it's magic on that version. However, 0.1.1 required roman to be installed (via pip), and since then we've incorporated that code into our package (as plasmapy.utils.roman).

The point of my question is: if we released 0.1.2 from the current snapshot onto PyPI and changed the version to 0.1.2 here, would this pass?

A second, related question, since I'd like to verify this - is there a way to test a recipe locally? I found the commit --amend; push -f trick in this repo's readme. If not, @SolarDrew - could I ask you for collaborator rights on this branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.