Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add r-swagger #9597

Merged
merged 3 commits into from Sep 19, 2019

Conversation

@xhochy
Copy link
Member

xhochy commented Sep 19, 2019

Used conda_r_skeleton_helper.

Checklist

  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vend other packages
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your
    recipe (see
    here
    for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there
@conda-forge-linter

This comment was marked as resolved.

Copy link

conda-forge-linter commented Sep 19, 2019

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-swagger) and found some lint.

Here's what I've got...

For recipes/r-swagger:

  • The recipe license should not include the word "License".

For recipes/r-swagger:

  • license_file entry is missing, but is expected.
@conda-forge-linter

This comment has been minimized.

Copy link

conda-forge-linter commented Sep 19, 2019

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/r-swagger) and found it was in an excellent condition.

@xhochy

This comment has been minimized.

Copy link
Member Author

xhochy commented Sep 19, 2019

@conda-forge/staged-recipes This is ready for review/merge. As always used the conda_r_skeleton_helper.

@cbrueffer

This comment has been minimized.

Copy link
Member

cbrueffer commented Sep 19, 2019

Any reason to commit the license file to the repo instead of just using license_file: LICENSE?

@dbast

This comment has been minimized.

Copy link
Member

dbast commented Sep 19, 2019

The license file handling of included licenses will get easier with the work currently on conda-build master branch. Hope that gets released soon.

@xhochy xhochy force-pushed the xhochy:r-swagger branch from 89dfcb2 to 71fabbb Sep 19, 2019
@xhochy xhochy force-pushed the xhochy:r-swagger branch from 71fabbb to 03ddff8 Sep 19, 2019
@xhochy

This comment has been minimized.

Copy link
Member Author

xhochy commented Sep 19, 2019

At first look, it seemed that the LICENSE was not uploaded to CRAN but it actually is. Removed the license file again.

CI is passing ;)

@mariusvniekerk mariusvniekerk merged commit f653ca8 into conda-forge:master Sep 19, 2019
6 checks passed
6 checks passed
conda-forge-linter All recipes are excellent.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
staged-recipes Build #20190919.19 succeeded
Details
staged-recipes (linux_64 linux) linux_64 linux succeeded
Details
staged-recipes (osx_64 osx) osx_64 osx succeeded
Details
staged-recipes (win_64 win) win_64 win succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.