Wheel output based on build steps and meta.yaml #1706

Open
msarahan opened this Issue Jan 27, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@msarahan
Contributor

msarahan commented Jan 27, 2017

presently, conda-build's support for wheels is based on just running bdist_wheel. This is effectively just doing the build twice. It would be better to make wheels be more simply a packaging process, though this may duplicate more code from setuptools/pip/wheel.

@msarahan

This comment has been minimized.

Show comment
Hide comment
@msarahan

msarahan Mar 3, 2017

Contributor

This should also use the wheel packaging tools - delocate seems especially relevant: https://github.com/matthew-brett/delocate

Contributor

msarahan commented Mar 3, 2017

This should also use the wheel packaging tools - delocate seems especially relevant: https://github.com/matthew-brett/delocate

@msarahan msarahan added this to the 3.0.0 milestone Mar 3, 2017

@msarahan

This comment has been minimized.

Show comment
Hide comment
@msarahan

msarahan Jun 6, 2017

Contributor

Punting to 3.1.0. Need to get 3.0.0 out.

Contributor

msarahan commented Jun 6, 2017

Punting to 3.1.0. Need to get 3.0.0 out.

@msarahan msarahan modified the milestones: 3.1.0, 3.0.0 Jun 6, 2017

@jakirkham

This comment has been minimized.

Show comment
Hide comment
@jakirkham

jakirkham Mar 5, 2018

Contributor

FWIW didn't seem to have any issues just reusing the build artifacts from building the conda package in the wheel packaging step. So FWICT this already works.

Contributor

jakirkham commented Mar 5, 2018

FWIW didn't seem to have any issues just reusing the build artifacts from building the conda package in the wheel packaging step. So FWICT this already works.

@msarahan

This comment has been minimized.

Show comment
Hide comment
@msarahan

msarahan Mar 6, 2018

Contributor

what are your build steps? what artifacts are you reusing? I guess if the binaries or whatever are in the right build folder, then pip or wheel or whatever the tool is will find them? In which case, we need to make sure that the conda builds come first, and that we also add in auditwheel or whatever extra repackaging is necessary.

Contributor

msarahan commented Mar 6, 2018

what are your build steps? what artifacts are you reusing? I guess if the binaries or whatever are in the right build folder, then pip or wheel or whatever the tool is will find them? In which case, we need to make sure that the conda builds come first, and that we also add in auditwheel or whatever extra repackaging is necessary.

@jakirkham

This comment has been minimized.

Show comment
Hide comment
@jakirkham

jakirkham Mar 6, 2018

Contributor

Generally have documented things in this comment with links to specific examples. Comments welcome in that thread as well.

Right, think that wheel is able to find them afterwards. They roughly all look like this. The rest of the diff is re-rendering, which can be ignored.

Contributor

jakirkham commented Mar 6, 2018

Generally have documented things in this comment with links to specific examples. Comments welcome in that thread as well.

Right, think that wheel is able to find them afterwards. They roughly all look like this. The rest of the diff is re-rendering, which can be ignored.

@jakirkham

This comment has been minimized.

Show comment
Hide comment
@jakirkham

jakirkham Mar 7, 2018

Contributor

Probably obvious, but guessing what I did won't work with build isolation. However build isolation would cause so many other problems that this would be merely another casualty on the list.

Contributor

jakirkham commented Mar 7, 2018

Probably obvious, but guessing what I did won't work with build isolation. However build isolation would cause so many other problems that this would be merely another casualty on the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment