ENH raise runtimeerror instead of calling sys.exit #4062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaconda-issue-bot
added
the
cla-signed
ocefpaf
reviewed
Sep 23, 2020
| @@ -612,7 +612,7 @@ def patch_or_reverse(patch, patch_args, cwd, stdout, stderr): | |||
|
|
|||
| exception = None | |||
| if not isfile(path): | |||
| sys.exit('Error: no such patch: %s' % path) | |||
| raise RuntimeError('Error: no such patch: %s' % path) | |||
There was a problem hiding this comment.
You can raise SystemExit and keep "similar" to what happened before with a nicer way to catch. However, I agree that this is more like a run time error instead.
There was a problem hiding this comment.
Right and agreed a RuntimeError is better. The issue is if a user is catching errors, they cannot use Exception since SystemExit doesn't inherit from that. Asking users to catch SystemExit is dangerous and definitely a python anti-pattern.
|
Thanks @beckermr |
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4061
cc @mingwandroid @jjhelmus