Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the git lfs error by adding git lfs fetching #4318

Merged
merged 8 commits into from Feb 23, 2023

Conversation

ernstluring
Copy link
Contributor

This PR addresses issue #1462 and is a part of the solution that fixes the failing clone from a source with LFS files.
I have added a runtime check if the repo uses git lfs and a git lfs fetch call that fetches all LFS files, so it can be copied to the destination directory later on.

@anaconda-issue-bot
Copy link

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @ernstluring. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@ernstluring ernstluring changed the title Fixes the git lfs erro by adding git lfs fetching Fixes the git lfs error by adding git lfs fetching Nov 4, 2021
@jezdez
Copy link
Member

jezdez commented Nov 16, 2021

@anaconda-issue-bot check

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Nov 16, 2021
@baszalmstra
Copy link

Any idea why the pipelines fail? Is it because git lfs on CI is not the correct version?

@xhochy
Copy link
Contributor

xhochy commented Dec 13, 2022

@jezdez Is there anything I can do to bring this over the finish line? I also run into the problem today and would like to get it fixed.

Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, nothing serious.

conda_build/source.py Outdated Show resolved Hide resolved
conda_build/source.py Outdated Show resolved Hide resolved
@beeankha
Copy link
Contributor

pre-commit.ci autofix

beeankha
beeankha previously approved these changes Feb 23, 2023
@beeankha beeankha added type::bug describes erroneous operation, use severity::* to classify the type source::anaconda created by members of Anaconda, Inc. labels Feb 23, 2023
@kenodegard kenodegard linked an issue Feb 23, 2023 that may be closed by this pull request
@kenodegard kenodegard enabled auto-merge (squash) February 23, 2023 17:10
@kenodegard kenodegard merged commit 5ebe12b into conda:main Feb 23, 2023
24 checks passed
@cwharris
Copy link

This update has monetary implications for anyone using conda-build with GIT LFS. Using LFS with GitHub, for instance, costs money. If someone is using conda-build for each commit but isn't already using LFS as part of their checks (build, test, etc), this update is going to start downloading LFS files for those users.

This feature should be opt-in by default.

@jakirkham
Copy link
Member

Would it make sense to convert this request to an issue?

@h-vetinari
Copy link
Contributor

I'm still seeing an error with conda-build 3.24.0 related to a git_url: source. I left a comment in #1462, but happy to open a new issue.

@jakirkham
Copy link
Member

Yeah a new issue sounds like a good idea (just to make sure that doesn't get lost in a closed one)

@h-vetinari
Copy link
Contributor

Yeah a new issue sounds like a good idea (just to make sure that doesn't get lost in a closed one)

#4882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA source::anaconda created by members of Anaconda, Inc. type::bug describes erroneous operation, use severity::* to classify the type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clone fails if source has LFS files
10 participants