Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the "Generated an index" example to include more platforms. #4602

Merged
merged 10 commits into from
Nov 3, 2022
Merged

Updated the "Generated an index" example to include more platforms. #4602

merged 10 commits into from
Nov 3, 2022

Conversation

tnabtaf
Copy link
Contributor

@tnabtaf tnabtaf commented Oct 14, 2022

Description

As documented in issue #4601 I had issues following the 'build a channel index' example in the docs. This PR adds support for Windows and the new Apple Silicon to the list. Also adds a section about how to get wget if you don't already have it.

Resolves #4601

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 14, 2022
travishathaway
travishathaway previously approved these changes Oct 17, 2022
Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things. Thanks for looking into this, Dave!

docs/source/concepts/generating-index.rst Outdated Show resolved Hide resolved
docs/source/concepts/generating-index.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this, Dave! I trust you tested it as much as you were able, so approved!

@tnabtaf
Copy link
Contributor Author

tnabtaf commented Oct 31, 2022

@kathatherine I tested this on a clean Windows 10 install.

@jezdez jezdez merged commit 1d6f64d into conda:main Nov 3, 2022
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Nov 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Doc "Concepts » Channels and generating an index" not working on osx-arm64
5 participants