Remove transient dependency on conda vendored six.py, and py2 code. #4603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
|
Hi @erykoff, We really appreciate this pull request and the fact that you are helping us tame some technical debt 💪 . Could you please add a news item like you already did for your other pull request in conda? (conda/conda#11979) Thank you. |
|
Also, once that is done and assuming this passes all the tests, I will be happy to give my approval on it ✅. |
|
Thanks! I added the news fragment, but I don't have the power to make the tests run. (Also the previous workflow tests did fail with a strange problem on one of the linux parallel tests). |
|
Failure on Windows 3.9, canary, parallel with "permission denied"? |
|
@erykoff re-running this test. Sometimes these things fail randomly. |
|
It worked! |
travishathaway
approved these changes
Oct 19, 2022
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following conda/conda#11979, I thought it was worthwhile to remove the transient dependency on conda's vendored six.py.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?