-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made changes as suggested by Issue #12055 #4782
Conversation
Line 266: ```from EXAMPLE: python=3.4 is translated to python 3.4*.``` to ```EXAMPLE: python=3.4 is translated to python 3.4.*. ``conda search 'python=3.1'`` does NOT bring up Python 3.10, only Python 3.1.*.``` Line 318: from matched as any version of a package named ``python>=2.7.0``. to ```matched as any version of a package named python 2.7.0 or python=2.7.18.```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this. I just have one question!
changed line 317 and line 266
changed line 266 and line 317
changed line no. 266 ,317 ,320
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, now that I've figured my error out, I have one more suggestion.
Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>
|
Hello @kathatherine, Thankyou for review, |
|
There isn't! As long as a maintainer with merge privileges is good with it, they'll merge it. I don't have those privileges yet, but I'll remind the core team this PR is here. Thank you for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
|
@sven6002 Are you able to merge this? I can't. |
|
Yes I can... |
|
@kathatherine @sven6002 Thank you for giving me this opportunity changes made in Line 317: requires little change, This happened because changes were looking good on GitHub preview need to remove Backtick from |
|
That is so strange! Those backticks should work. I deleted them and re-added them on my own local copy and they seem to be giving the correct formatting. Maybe there's some sort of problem pairing them with the quotes. Since this PR is already merged, I recommend creating a new branch in your fork and making the changes there. Just tag me in your new PR and we can go from there. |

Description
Errors in package spec documentation:
Made few changes in document docs/source/resources/package-spec.rst
Change made
Line 266:
from EXAMPLE: python=3.4 is translated to python 3.4*.to
EXAMPLE: python=3.4 is translated to python 3.4.*. ``conda search 'python=3.1'`` does NOT bring up Python 3.10, only Python 3.1.*.Line 317:
invalid match specification. Furthermore, python>=2.7 isto
invalid match specification. Furthermore,"python >= 2.7" with double or single quotes isLine 320:
When using the command line, put double quotes around any packageto
When using the command line, put double or single quotes around any packagein docs/source/resources/package-spec.rst
Issue solved
Fixes: #12055
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?