Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes as suggested by Issue #12055 #4782

Merged
merged 10 commits into from
May 15, 2023
Merged

Made changes as suggested by Issue #12055 #4782

merged 10 commits into from
May 15, 2023

Conversation

rishabh11336
Copy link
Contributor

@rishabh11336 rishabh11336 commented Feb 22, 2023

Description

Errors in package spec documentation:

Made few changes in document docs/source/resources/package-spec.rst

Change made

  • Line 266:
    from EXAMPLE: python=3.4 is translated to python 3.4*.
    to
    EXAMPLE: python=3.4 is translated to python 3.4.*. ``conda search 'python=3.1'`` does NOT bring up Python 3.10, only Python 3.1.*.

  • Line 317:
    invalid match specification. Furthermore, python>=2.7 is
    to
    invalid match specification. Furthermore,"python >= 2.7" with double or single quotes is

  • Line 320:
    When using the command line, put double quotes around any package
    to
    When using the command line, put double or single quotes around any package

in docs/source/resources/package-spec.rst

Issue solved

Fixes: #12055

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

Line 266:  ```from EXAMPLE: python=3.4 is translated to python 3.4*.```  to ```EXAMPLE: python=3.4 is translated to python 3.4.*. ``conda search 'python=3.1'`` does NOT bring up Python 3.10, only Python 3.1.*.```

Line 318:  from matched as any version of a package named ``python>=2.7.0``. to ```matched as any version of a package named python 2.7.0 or python=2.7.18.```
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Feb 22, 2023
@jezdez jezdez added the documentation::reference related to the API and internals (information-oriented) label May 8, 2023
Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this. I just have one question!

docs/source/resources/package-spec.rst Outdated Show resolved Hide resolved
docs/source/resources/package-spec.rst Outdated Show resolved Hide resolved
docs/source/resources/package-spec.rst Outdated Show resolved Hide resolved
changed line no. 266 ,317 ,320
Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, now that I've figured my error out, I have one more suggestion.

docs/source/resources/package-spec.rst Outdated Show resolved Hide resolved
Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>
@rishabh11336
Copy link
Contributor Author

Hello @kathatherine, Thankyou for review,
Am I missing something, Or there is some procedure for merging of this PR.
If there anything more I need to do Please let me Know.

@kathatherine
Copy link
Contributor

There isn't! As long as a maintainer with merge privileges is good with it, they'll merge it. I don't have those privileges yet, but I'll remind the core team this PR is here. Thank you for your contribution.

Copy link
Contributor

@sven6002 sven6002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kathatherine
Copy link
Contributor

@sven6002 Are you able to merge this? I can't.

@sven6002
Copy link
Contributor

Yes I can...

@travishathaway travishathaway merged commit 69976ed into conda:main May 15, 2023
@rishabh11336
Copy link
Contributor Author

rishabh11336 commented May 15, 2023

@kathatherine @sven6002 Thank you for giving me this opportunity
While looking at documentation, I figured
image

changes made in Line 317: requires little change, This happened because changes were looking good on GitHub preview

need to remove Backtick from "python >= 2.7" line 317 in last PR
Kindly guide me in the process

@kathatherine
Copy link
Contributor

kathatherine commented May 15, 2023

That is so strange! Those backticks should work. I deleted them and re-added them on my own local copy and they seem to be giving the correct formatting. Maybe there's some sort of problem pairing them with the quotes.

Since this PR is already merged, I recommend creating a new branch in your fork and making the changes there. Just tag me in your new PR and we can go from there.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label May 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA documentation::reference related to the API and internals (information-oriented) locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Errors in package spec documentation
6 participants