Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version specification regular expression pattern #29

Merged
merged 6 commits into from
Dec 3, 2017

Conversation

mandeep
Copy link
Contributor

@mandeep mandeep commented Oct 19, 2017

fixes #25
fixes #33

This regular expression matches the specification provided in the package match specifications: https://conda.io/docs/user-guide/tasks/build-packages/package-spec.html#build-version-spec

I'm no regular expression expert, so if there's something that is more efficient please let me know.

Fix ver_spec_pat regular expession
@mandeep mandeep added the Status: Review Needed [deprecated] use milestones/project boards label Oct 19, 2017
@msarahan
Copy link
Contributor

msarahan commented Dec 4, 2017

Thanks @mandeep

@mariusvniekerk
Copy link

mariusvniekerk commented Mar 2, 2018

@mandeep @msarahan Can we have a release for this? With the recent release of 3.0.1 on conda-forge it fails verification on several recipes.

@msarahan
Copy link
Contributor

msarahan commented Mar 2, 2018

@mariusvniekerk 3.0.2 is tagged. It is known to fail tests with conda-build 3, but we think those are OK (conda-build stripping out errors before conda-verify sees them - not ideal, but functional).

@mariusvniekerk
Copy link

👍 yay

@mandeep mandeep deleted the fix-ver-spec-pat branch March 3, 2018 01:45
@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity Status: Review Needed [deprecated] use milestones/project boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda Verify marks valid spec containing '|' as invalid version spec pattern broken?
3 participants