Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore virtual packages when checking environment consistency #10196

Merged

Conversation

ericpre
Copy link
Contributor

@ericpre ericpre commented Aug 27, 2020

In conda-forge/prismatic_split-feedstock#10, I have added __cuda as a run dependency to restrict the installation of the GPU build on compatible system, which is working very well! A side effect of this is to make the environment inconsistent because the __cuda virtual package is not installed.

For example, on an CUDA capable linux system (there is no cuda package for windows):

$ conda install prismatic_cli -c conda-forge
$ conda update --all
Collecting package metadata (current_repodata.json): done
Solving environment: / 
The environment is inconsistent, please check the package plan carefully
The following packages are causing the inconsistency:

  - conda-forge/linux-64::prismatic_cli==1.2.1=gpu_h5deb2e2_108
done

# All requested packages already installed.

@ericpre ericpre requested a review from a team as a code owner August 27, 2020 17:13
@cla-bot cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 27, 2020
@ericpre
Copy link
Contributor Author

ericpre commented Aug 28, 2020

I forgot to mention that the issue is with the warning being wrong, conda doesn't raise any error and there is no inconsistency in the environment. This PR fixes the warning and the approach is similar as the one used in #10117.

@jjhelmus, @chenghlee, could you please have a look at this PR?

@ericpre
Copy link
Contributor Author

ericpre commented Sep 22, 2020

Anyone to review this PR?

@chenghlee chenghlee added this to the 4.9.0 milestone Sep 29, 2020
@chenghlee
Copy link
Contributor

Closing & re-opening this PR to force checks with new CI system.

@chenghlee chenghlee closed this Oct 4, 2020
@chenghlee chenghlee reopened this Oct 4, 2020
@ericpre
Copy link
Contributor Author

ericpre commented Oct 8, 2020

Thanks @chenghlee, CI seems to be happy now!

@chenghlee chenghlee merged commit 0fa1d47 into conda:master Oct 9, 2020
@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Oct 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants