[tests] conda_env create tests confuse -f and -n

[javabrett]

When a prefix is passed to run_env_command with Commands.ENV_CREATE it should be passed to -n, not -f. Fixed that and corrected tests calling that helper method.

Noticed while investigating #8192.

[msarahan]

Thanks for looking into this. I'm pretty sure you're right, but I'll spend a bit more time double-checking the positional arg stuff.

[msarahan]

I think we should test prefix to see if it is path-like (has slashes, leading periods, is an abspath, etc.). If it is a path, this should be -p. If it's a name, it should be -n.

[javabrett]

I hadn't considered -p. It's also possible I'm not across any overloaded meaning of the terms prefix and name, which are used interchangeably in the code in places.

None of the existing tests make use of -p, so there might be some coverage options there. Hopefully none of the existing tests pass a path-type -n - this arg is positional prefix, or so it seems.

Existing tests are mostly creating by name and file, but important to test that the name takes priority in the created env I guess. Just looked wrong that the prefix was passed to file in this one case, and test callers were bent to fit that.

Eventually these tests need to point out issues in

conda/conda_env/specs/__init__.py

Lines 15 to 18 in 9a303dc

	def detect(**kwargs):
	filename = kwargs.get('filename')
	remote_definition = kwargs.get('name')

... where remote def and name might be passed in a single kwarg without being able to distinguish between them, causing logic issues in that method.

[msarahan]

@javabrett has signed the CLA. Thanks for your contribution!

[github-actions]

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.