Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install WebDrivers automatically #31

Open
colatkinson opened this issue Oct 26, 2017 · 1 comment
Open

Install WebDrivers automatically #31

colatkinson opened this issue Oct 26, 2017 · 1 comment

Comments

@colatkinson
Copy link
Contributor

@colatkinson colatkinson commented Oct 26, 2017

As of right now, the framework requires manual installation of platform-appropriate WebDrivers. There is a Maven plugin that handles this exact problem.

Would you consider any of the following as acceptable changes to the framework?

  1. Integrating with this plugin. As of right now, my solution to getting the two to work together involves some hacky bash scripting
  2. Loading the drivers from the resources folder. This would allow the project to work when packed into a JAR

If there are established solutions to these problems, I apologize, but I couldn't find any. I would be more than willing to work on a PR.

@ddavison
Copy link
Member

@ddavison ddavison commented Oct 26, 2017

I'd definitely be up for both of these. Interacting with a plugin that can automatically install these drivers would be awesome. About the bash hacking: yea i believe it. Conductor expects the drivers to be named specifically (chromdriver.mac, .linux, .exe). If we could find away to distinguish them using the plugin, that'd be awesome.

Moving the drivers to the src/test/resources directory wouldn't really be against any convention, so i have no problem with that, either!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants