Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load drivers from resources instead of project root #32

Merged

Conversation

@colatkinson
Copy link
Contributor

commented Oct 27, 2017

The webdrivers are stored in the resources folder of the project using the framework, and are extracted to temporary files at runtime. This allows them to be packed into JARs for easy distribution. The project using the framework will be responsible for the installation of the webdrivers, but the framework now uses the same naming scheme as webdriverextensions-maven-plugin, so this is trivially easy.

I incremented the patch number for ease of testing, but I don't know what convention you use for versioning.

colatkinson added some commits Oct 27, 2017

@ddavison

This comment has been minimized.

Copy link
Member

commented Oct 27, 2017

this looks fantastic.. give me until tomorrow to merge it in.

@colatkinson

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2017

Any updates on merging this? It'd be cool to be able to pull it in from Maven. No rush though.

@ddavison

This comment has been minimized.

Copy link
Member

commented Nov 2, 2017

one question - not sure of the availability of these, but it's at least smart to be future proof. what if we want to use the 64 bit version of any of these drivers? 32bit is hard-coded in your extractDriver() method

@colatkinson

This comment has been minimized.

Copy link
Contributor Author

commented Nov 2, 2017

There are 64-bit versions of the drivers available. I hardcoded in 32-bit for simplicity's sake. I agree, though, futureproofing is probably a good move.

How do you think this should be handled? The best solution I can see is packaging both versions of the binaries and deciding which to use at runtime. Can you think of a better way?

@colatkinson

This comment has been minimized.

Copy link
Contributor Author

commented Nov 7, 2017

@ddavison I've implemented a simple method to use architecture-appropriate webdrivers if they are present. If not, it will fall back on the 32-bit version. Let me know what you think.

@ddavison ddavison merged commit fc9843c into conductor-framework:master Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.