Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

[HttpFoundation] fixed exception message (closes #3123)

  • Loading branch information...
commit 733ac9de7ab84b8136d789416e9f42d902d303a4 1 parent 33170ae
@fabpot fabpot authored
View
2  src/Symfony/Component/HttpFoundation/Response.php
@@ -672,7 +672,7 @@ public function setEtag($etag = null, $weak = false)
public function setCache(array $options)
{
if ($diff = array_diff(array_keys($options), array('etag', 'last_modified', 'max_age', 's_maxage', 'private', 'public'))) {
- throw new \InvalidArgumentException(sprintf('Response does not support the following options: "%s".', implode('", "', array_keys($diff))));
+ throw new \InvalidArgumentException(sprintf('Response does not support the following options: "%s".', implode('", "', array_values($diff))));
}
if (isset($options['etag'])) {
View
1  tests/Symfony/Tests/Component/HttpFoundation/ResponseTest.php
@@ -219,6 +219,7 @@ public function testSetCache()
$this->fail('->setCache() throws an InvalidArgumentException if an option is not supported');
} catch (\Exception $e) {
$this->assertInstanceOf('InvalidArgumentException', $e, '->setCache() throws an InvalidArgumentException if an option is not supported');
+ $this->assertContains('"wrong option"', $e->getMessage());
}
$options = array('etag' => '"whatever"');
Please sign in to comment.
Something went wrong with that request. Please try again.