New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CC-14690 : Define com.fasterxml.jackson.dataformat:jackson-dataformat-cbor. #334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you include a ticket ID at the front of the PR title and an explanation of the motivation? By itself this doesn't really do anything, and if we need to explicitly override a specific jar, I would expect there to be an addition to the dependencyManagement
section.
Yep. Included the ticket id and also add context in the description. |
You would put it in dependencyManagement here, and then downstreams would not specify a version, they should just use the one here by default if they specify just the |
Added dependecy and also https://github.com/confluentinc/kafka-connect-storage-cloud/pull/415/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as we've a) verified this against the other PR (and e.g. that there aren't compatibility issues between this version and the other jackson-bom versions) and b) this is the oldest branch we need this on.
…-cbor. (#334) * Define com.fasterxml.jackson.dataformat:jackson-dataformat-cbor version property * Fix comment
This is to define the com.fasterxml.jackson.dataformat:jackson-dataformat-cbor version as a property in common so that all downstream consumers can use the property. The purpose is to unify the non-vulnerable version of shared libraries in common. This provides convenience when we need to upgrade this in the future.
We could define this in the dependencyManagement in the specific repo, but that does no scale because this could be used in multiple places. For now, this will be used confluentinc/kafka-connect-storage-cloud#415