Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #723 #787

Merged
merged 1 commit into from Jun 21, 2022
Merged

fixes #723 #787

merged 1 commit into from Jun 21, 2022

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Jun 3, 2022

documentation links have been updated with the new go.dev static files

@emasab emasab requested review from jliunyu and edenhill Jun 3, 2022
@emasab emasab force-pushed the bugfix/issue-723 branch 2 times, most recently from b3caf60 to 5180815 Compare Jun 6, 2022
Copy link
Contributor

@edenhill edenhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, when reverting generated_errors.go

kafka/generated_errors.go Outdated Show resolved Hide resolved
changed references to the new go.dev site.
Some improvements, but it could be deprecated
as it's better to read the api doc through
https://pkg.go.dev/github.com/confluentinc/confluent-kafka-go
@emasab emasab merged commit 9c586e3 into master Jun 21, 2022
3 of 4 checks passed
@emasab emasab deleted the bugfix/issue-723 branch Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants