Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Go client examples #801

Merged
merged 3 commits into from Jun 21, 2022
Merged

Improvements to Go client examples #801

merged 3 commits into from Jun 21, 2022

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Jun 21, 2022

  • Changed the producer example to use the Events delivery channel.
  • Added another producer example using a custom delivery channel
  • Moved channel producer and consumer examples to the
    examples/legacy folder
  • Added missing descriptions for other examples
  • Consumer example with at-least-once guarantee by disabling
    enable.auto.offset.store and using StoreMessage

- Changed the producer example to use the Events delivery channel.
- Added another producer example using a custom delivery channel
- Moved channel producer and consumer examples to the
  examples/legacy folder
- Added missing descriptions for other examples
- Consumer example with at-least-once guarantee by disabling
  enable.auto.offset.store and using StoreMessage
a channel for each Produce call
README.md Outdated Show resolved Hide resolved
examples/.gitignore Outdated Show resolved Hide resolved
examples/producer_example/producer_example.go Show resolved Hide resolved
@emasab emasab force-pushed the feature/better-examples branch 2 times, most recently from 5f7a94e to d452030 Compare Jun 21, 2022
@emasab emasab force-pushed the feature/better-examples branch from d452030 to cb15412 Compare Jun 21, 2022
Copy link
Contributor

@edenhill edenhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emasab emasab merged commit b89b9e4 into master Jun 21, 2022
3 of 4 checks passed
@emasab emasab deleted the feature/better-examples branch Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants