From 50efa73a0f8a774002dc3021ab31c0bcb62ce353 Mon Sep 17 00:00:00 2001 From: didier deshommes Date: Thu, 21 Jul 2016 14:00:34 -0500 Subject: [PATCH 1/2] Correct typo for example in README --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 23bf7ea12..475ee4410 100644 --- a/README.md +++ b/README.md @@ -35,7 +35,7 @@ from confluent_kafka import Consumer c = Consumer({'bootstrap.servers': 'mybroker', 'group.id': 'mygroup', 'default.topic.config': {'auto.offset.reset': 'smallest'}}) c.subscribe(['mytopic']) -while running: +while True: msg = c.poll() if not msg.error(): print('Received message: %s' % msg.value().decode('utf-8')) From 46375fc6706d68286201a5532065a8ce2bb33cf5 Mon Sep 17 00:00:00 2001 From: didier deshommes Date: Thu, 28 Jul 2016 21:32:52 -0500 Subject: [PATCH 2/2] Update README high-level consumer example Update the example to show that upon exit, the consumer must call `close()` --- README.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 475ee4410..777d7822a 100644 --- a/README.md +++ b/README.md @@ -35,10 +35,13 @@ from confluent_kafka import Consumer c = Consumer({'bootstrap.servers': 'mybroker', 'group.id': 'mygroup', 'default.topic.config': {'auto.offset.reset': 'smallest'}}) c.subscribe(['mytopic']) -while True: +running = True +while running: msg = c.poll() if not msg.error(): print('Received message: %s' % msg.value().decode('utf-8')) + else: + running = False c.close() ```