Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release for CP 5.3.0 #114

Merged
merged 77 commits into from Jul 26, 2019

Conversation

@JumaX
Copy link
Member

commented Jul 24, 2019

Updating playbooks to supported state for CP 5.3.0.

@domenicbove Please review.

xnulinu and others added 30 commits May 2, 2019
modified: README.md
	new file:   all.yml
	new file:   ansible.cfg
	new file:   hosts.yml

Initial Commit.
new file: LICENSE
	new file:   docs/Makefile
	new file:   docs/index.rst
	new file:   plaintext/all.yml
	new file:   plaintext/hosts.yml
	new file:   roles/confluent.common/defaults/main.yml
	new file:   roles/confluent.common/handlers/main.yml
	new file:   roles/confluent.common/tasks/debian.yml
	new file:   roles/confluent.common/tasks/main.yml
	new file:   roles/confluent.common/tasks/redhat.yml
	new file:   roles/confluent.common/tasks/ssl_certs.yml
	new file:   roles/confluent.connect-distributed/defaults/main.yml
	new file:   roles/confluent.connect-distributed/handlers/main.yml
	new file:   roles/confluent.connect-distributed/meta/main.yml
	new file:   roles/confluent.connect-distributed/tasks/main.yml
	new file:   roles/confluent.connect-distributed/templates/connect-distributed.properties.j2
	new file:   roles/confluent.connect-distributed/templates/connect-distributed_sasl_ssl.properties.j2
	new file:   roles/confluent.connect-distributed/templates/connect-distributed_ssl.properties.j2
	new file:   roles/confluent.connect-distributed/templates/environment.j2
	new file:   roles/confluent.connect-distributed/templates/includes/base_connect-distributed.properties.j2
	new file:   roles/confluent.connect-distributed/templates/includes/schema_registry_urls.j2
	new file:   roles/confluent.control-center/defaults/main.yml
	new file:   roles/confluent.control-center/handlers/main.yml
	new file:   roles/confluent.control-center/meta/main.yml
	new file:   roles/confluent.control-center/tasks/main.yml
	new file:   roles/confluent.control-center/templates/control-center.properties.j2
	new file:   roles/confluent.control-center/templates/control-center_sasl_ssl.properties.j2
	new file:   roles/confluent.control-center/templates/control-center_ssl.properties.j2
	new file:   roles/confluent.control-center/templates/environment.j2
	new file:   roles/confluent.control-center/templates/includes/base_control-center.properties.j2
	new file:   roles/confluent.kafka-broker/defaults/main.yml
	new file:   roles/confluent.kafka-broker/handlers/main.yml
	new file:   roles/confluent.kafka-broker/meta/main.yml
	new file:   roles/confluent.kafka-broker/tasks/main.yml
	new file:   roles/confluent.kafka-broker/templates/environment.j2
	new file:   roles/confluent.kafka-broker/templates/includes/base_server.properties.j2
	new file:   roles/confluent.kafka-broker/templates/includes/confluent_support.j2
	new file:   roles/confluent.kafka-broker/templates/server.properties.j2
	new file:   roles/confluent.kafka-broker/templates/server_sasl_ssl.properties.j2
	new file:   roles/confluent.kafka-broker/templates/server_ssl.properties.j2
	new file:   roles/confluent.kafka-rest/defaults/main.yml
	new file:   roles/confluent.kafka-rest/handlers/main.yml
	new file:   roles/confluent.kafka-rest/meta/main.yml
	new file:   roles/confluent.kafka-rest/tasks/main.yml
	new file:   roles/confluent.kafka-rest/templates/environment.j2
	new file:   roles/confluent.kafka-rest/templates/includes/base_kafka-rest.properties.j2
	new file:   roles/confluent.kafka-rest/templates/kafka-rest.properties.j2
	new file:   roles/confluent.kafka-rest/templates/kafka-rest_sasl_ssl.properties.j2
	new file:   roles/confluent.kafka-rest/templates/kafka-rest_ssl.properties.j2
	new file:   roles/confluent.ksql/defaults/main.yml
	new file:   roles/confluent.ksql/handlers/main.yml
	new file:   roles/confluent.ksql/meta/main.yml
	new file:   roles/confluent.ksql/tasks/main.yml
	new file:   roles/confluent.ksql/templates/environment.j2
	new file:   roles/confluent.ksql/templates/includes/base_ksql.properties.j2
	new file:   roles/confluent.ksql/templates/ksql.properties.j2
	new file:   roles/confluent.ksql/templates/ksql_sasl_ssl.properties.j2
	new file:   roles/confluent.ksql/templates/ksql_ssl.properties.j2
	new file:   roles/confluent.preflight/tasks/debian.yml
	new file:   roles/confluent.preflight/tasks/main.yml
	new file:   roles/confluent.preflight/tasks/redhat.yml
	new file:   roles/confluent.schema-registry/defaults/main.yml
	new file:   roles/confluent.schema-registry/handlers/main.yml
	new file:   roles/confluent.schema-registry/meta/main.yml
	new file:   roles/confluent.schema-registry/tasks/main.yml
	new file:   roles/confluent.schema-registry/templates/environment.j2
	new file:   roles/confluent.schema-registry/templates/includes/base_schema-registry.properties.j2
	new file:   roles/confluent.schema-registry/templates/schema-registry.properties.j2
	new file:   roles/confluent.schema-registry/templates/schema-registry_sasl_ssl.properties.j2
	new file:   roles/confluent.schema-registry/templates/schema-registry_ssl.properties.j2
	new file:   roles/confluent.ssl_CA/scripts/certs-create.sh
	new file:   roles/confluent.ssl_CA/tasks/main.yml
	new file:   roles/confluent.tools/defaults/main.yml
	new file:   roles/confluent.tools/meta/main.yml
	new file:   roles/confluent.tools/tasks/main.yml
	new file:   roles/confluent.tools/templates/includes/base_tools.properties.j2
	new file:   roles/confluent.tools/templates/tools.properties.j2
	new file:   roles/confluent.tools/templates/tools_sasl_ssl.properties.j2
	new file:   roles/confluent.tools/templates/tools_ssl.properties.j2
	new file:   roles/confluent.zookeeper/defaults/main.yml
	new file:   roles/confluent.zookeeper/handlers/main.yml
	new file:   roles/confluent.zookeeper/meta/main.yml
	new file:   roles/confluent.zookeeper/tasks/main.yml
	new file:   roles/confluent.zookeeper/templates/environment.j2
	new file:   roles/confluent.zookeeper/templates/myid.j2
	new file:   roles/confluent.zookeeper/templates/zookeeper.properties.j2
	new file:   sasl_ssl/all.yml
	new file:   sasl_ssl/hosts.yml
	new file:   ssl/all.yml
	new file:   ssl/hosts.yml
renamed: all.yml -> all.yml.original
	modified:   hosts.yml
	new file:   ssl_selfsigned/all.yml
	new file:   ssl_selfsigned/hosts.yml
	new file:   ssl_selfsigned/vars/security_vars.yml
modified: all.yml
	modified:   hosts.yml
	modified:   roles/confluent.kafka-broker/tasks/main.yml
	new file:   roles/confluent.kafka-broker/templates/server_ssl_self_signed.properties.j2
	new file:   roles/confluent.ssl_selfsigned/scripts/certs-create.sh
	new file:   roles/confluent.ssl_selfsigned/tasks/main.yml
new file: all.retry
	modified:   all.yml
	modified:   roles/confluent.ssl_selfsigned/scripts/certs-create.sh
	modified:   roles/confluent.ssl_selfsigned/tasks/main.yml
	new file:   ssl_selfsigned/vars/.security_vars.yml.swp
	modified:   ssl_selfsigned/vars/security_vars.yml
new file: .gitignore
	modified:   all.yml
	modified:   roles/confluent.kafka-broker/templates/server_ssl_self_signed.properties.j2
modified: .gitignore
	modified:   all.yml
	new file:   generated_ssl_files/broker_keystore_creds
	new file:   generated_ssl_files/broker_sslkey_creds
	new file:   generated_ssl_files/broker_truststore_creds
	new file:   generated_ssl_files/client_keystore_creds
	new file:   generated_ssl_files/client_sslkey_creds
	new file:   generated_ssl_files/client_truststore_creds
	new file:   generated_ssl_files/snakeoil-ca-1.srl
	modified:   roles/confluent.kafka-broker/templates/server_ssl_self_signed.properties.j2
modified: roles/confluent.kafka-broker/templates/server_ssl_self_sig…
…ned.properties.j2

	deleted:    ssl_selfsigned/vars/.security_vars.yml.swp
modified: .gitignore
	modified:   all.retry
	deleted:    generated_ssl_files/snakeoil-ca-1.srl
	modified:   roles/confluent.kafka-broker/defaults/main.yml
	new file:   "roles/confluent.ssl_selfsigned/scripts/\\"
	modified:   roles/confluent.ssl_selfsigned/scripts/certs-create.sh
	modified:   roles/confluent.ssl_selfsigned/tasks/main.yml
	modified:   ssl_selfsigned/vars/security_vars.yml
modified: roles/confluent.ssl_selfsigned/scripts/certs-create.sh
	modified:   roles/confluent.ssl_selfsigned/tasks/main.yml
	modified:   ssl_selfsigned/vars/security_vars.yml
modified: .gitignore
	deleted:    all.retry
	modified:   roles/confluent.kafka-broker/defaults/main.yml
	modified:   roles/confluent.kafka-broker/templates/server_ssl_self_signed.properties.j2
	deleted:    "roles/confluent.ssl_selfsigned/scripts/\\"
	renamed:    roles/confluent.ssl_selfsigned/scripts/certs-create.sh -> roles/confluent.ssl_selfsigned/scripts/certs-import.sh
	modified:   roles/confluent.ssl_selfsigned/tasks/main.yml
	modified:   ssl_selfsigned/vars/security_vars.yml
modified: all.yml
	modified:   roles/confluent.schema-registry/tasks/main.yml
	new file:   roles/confluent.schema-registry/templates/schema-registry_ssl_selfsigned.properties.j2
	modified:   roles/confluent.ssl_selfsigned/tasks/main.yml
modified: all.yml
	modified:   roles/confluent.connect-distributed/tasks/main.yml
	new file:   roles/confluent.connect-distributed/templates/connect-distributed_ssl_selfsigned.properties.j2
modified: all.yml
	modified:   roles/confluent.ksql/tasks/main.yml
	new file:   roles/confluent.ksql/templates/ksql_ssl_selfsigned.properties.j2
modified: all.yml
	modified:   roles/confluent.control-center/tasks/main.yml
	new file:   roles/confluent.control-center/templates/control-center_ssl_selfsigned.properties.j2
modified: all.yml
	modified:   roles/confluent.kafka-rest/tasks/main.yml
	new file:   roles/confluent.kafka-rest/templates/kafka-rest_ssl_selfsigned.properties.j2
modified: all.yml
	modified:   roles/confluent.tools/tasks/main.yml
	new file:   roles/confluent.tools/templates/tools_ssl_selfsigned.properties.j2
modified: .gitignore
	renamed:    all.yml.original -> all.yml
	modified:   ssl_selfsigned/all.yml
	modified:   ssl_selfsigned/vars/security_vars.yml
modified: README.md
	modified:   docs/index.rst
modified: index.rst
Modifications for new playbooks.
new file: CODE_OF_CONDUCT.md
	new file:   CONTRIBUTING.md
	new file:   PULL_REQUEST_TEMPLATE.md

Initial add of contribution details.
@@ -6,12 +6,19 @@ ksql:
systemd_override: /etc/systemd/system/confluent-ksql.service.d
user: cp-ksql
group: confluent
keytab: /etc/security/keytabs

This comment has been minimized.

Copy link
@domenicbove

domenicbove Jul 24, 2019

Contributor

should be shared var

This comment has been minimized.

Copy link
@JumaX

JumaX Jul 25, 2019

Author Member

please file a feature request for this, as this wasn't designed to be configurable in this version of the playbooks. We can certainly do this in a future release.

@@ -7,6 +7,9 @@ schema:
config_file: /etc/schema-registry/schema-registry.properties
service_name: confluent-schema-registry
systemd_override: /etc/systemd/system/confluent-schema-registry.service.d
realm: confluent.example.com

This comment has been minimized.

Copy link
@domenicbove

domenicbove Jul 24, 2019

Contributor

var not used anywhere

This comment has been minimized.

Copy link
@JumaX

JumaX Jul 25, 2019

Author Member

corrected.

echo "confluent" > ${i}_truststore_creds

# Create pem files and keys used for Schema Registry HTTPS testing
# openssl x509 -noout -modulus -in client.certificate.pem | openssl md5

This comment has been minimized.

Copy link
@domenicbove

domenicbove Jul 24, 2019

Contributor

remove commented code?

This comment has been minimized.

Copy link
@JumaX

JumaX Jul 25, 2019

Author Member

done.

@domenicbove
Copy link
Contributor

left a comment

Lot of minor things, but one bug i saw was around the kerberos realm using the wrong var. Ill try and fix today

domenicbove and others added 8 commits Jul 24, 2019
Merge pull request #116 from confluentinc/kerbos-bug
kerberos realm hardcoded to confluent.example.com
modified: tasks/main.yml
	renamed:    templates/kerberosenvironment.j2 -> templates/kerberos_environment.j2

Corrected naming convention on templates file.
modified: tasks/main.yml
	renamed:    templates/kerberosenvironment.j2 -> templates/kerberos_environment.j2

Changed naming convention to be more appropriate.
modified: roles/confluent.connect-distributed/defaults/main.yml
	modified:   roles/confluent.control-center/defaults/main.yml
	modified:   roles/confluent.kafka-rest/defaults/main.yml
	modified:   roles/confluent.schema-registry/defaults/main.yml
	modified:   roles/confluent.zookeeper/defaults/main.yml

Removed extraneous realm variable.
@domenicbove
Copy link
Contributor

left a comment

Looking good!

@domenicbove
Copy link
Contributor

left a comment

Looking good!

@JumaX JumaX merged commit 0bb8d6e into 5.3.x Jul 26, 2019

@JumaX JumaX deleted the 5.3.0-pre branch Jul 26, 2019

@JumaX JumaX restored the 5.3.0-pre branch Jul 26, 2019

@JumaX JumaX deleted the 5.3.0-pre branch Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.