Upgrade ES client to latest version #557
Merged
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 23, 2021 10:01
ilanjiR
commented
Jun 23, 2021
| <configuration> | ||
| <compilerArgs> | ||
| <arg>-Xlint:all,-try</arg> | ||
| <arg>-Werror</arg> |
Author
There was a problem hiding this comment.
This flag is causing the build to fail due to a deprecation warning. Not sure if there's a more elegant way to avoid the warning other than switching to the new builder (which looks complicated)
dosvath
approved these changes
Jun 23, 2021
There was a problem hiding this comment.
LGTM, @ilanjiR do go through the breaking changes between the last and new version here https://www.elastic.co/guide/en/elasticsearch/reference/7.13/es-release-notes.html, to make sure we're safe to upgrade. Not all upgrades have breaking changes, but best to check.
ilanjiR
pushed a commit
that referenced
this pull request
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The ES client we are on is from 2019
Solution
Upgrade the client to the latest version
Does this solution apply anywhere else?
If yes, where?
Test Strategy
Testing done:
Release Plan