Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "support multi partition fields." #108

Merged
merged 1 commit into from Aug 27, 2016

Conversation

Projects
None yet
4 participants
@shikhar
Copy link
Contributor

commented Aug 27, 2016

Reverts #105

@shikhar shikhar merged commit c9983ca into master Aug 27, 2016

1 check was pending

default Build triggered. sha1 is merged.
Details

@shikhar shikhar deleted the revert-105-#83 branch Aug 27, 2016

@doriwal

This comment has been minimized.

Copy link

commented on 00d980f Oct 6, 2016

Why did you revert this change ? it will be great to have the ability to partition by few fields
It didnt worked ? or what ?

This comment has been minimized.

Copy link

replied Nov 18, 2016

Can anyone please say why this was reverted? Also, will it be available in the future? The Multi-partition is a very useful one, absence of which has made my team to drop this from using.. Even though kafka-connect is the best there is.

This comment has been minimized.

Copy link

replied Nov 18, 2016

This comment has been minimized.

Copy link

replied May 10, 2017

+1 would love to have support for multiple partitions. My use case is DayID and HourID (i.e. DayID=20170510/HourID=14)

@shikhar

This comment has been minimized.

Copy link
Contributor Author

commented Nov 18, 2016

@doriwal @pritukam
#105 (comment)

A PR that passes tests welcome :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.