Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TimeBasedPartitioner config validation #126

Merged
merged 1 commit into from Sep 26, 2016

Conversation

Projects
None yet
2 participants
@cotedm
Copy link
Contributor

commented Sep 24, 2016

This PR is to fix the TimeBasedPartitioner validation. Today it returns visible=false for partition.duration.ms if you call config/validate with the TimeBasedPartitioner set. @shikhar can you review?

@shikhar shikhar merged commit c12983c into confluentinc:master Sep 26, 2016

1 check passed

default Build finished.
Details
@shikhar

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2016

LGTM

@cotedm cotedm deleted the cotedm:timebasedvalidationfix branch Sep 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.