CC-8750: Changed the dialects to sanitize all URL properties that case-insensitively contain “password” #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-insensitively contain “password” Now sanitizing any URL property that case-insensitively contains (and not just equal to) `password`. Also added a few dialect-specific tests to ensure that different dialects are sanitizing DBMS-specific properties.
gharris1727
approved these changes
Jun 8, 2020
There was a problem hiding this comment.
If the user forgets an equals and provides a query string like ?passwordmy-password&something=blah the next option will get sanitized: ?passwordmy-password&something-else=****.
This is probably not an edge case worth considering, and it wasn't covered by the previous regex at all.
LGTM, thanks @rhauch!
|
Thanks, @gharris1727. I've updated the regex to account for property names that contain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now sanitizing any URL property that case-insensitively contains (and not just equal to)
password. Also added a few dialect-specific tests to ensure that different dialects are sanitizing DBMS-specific properties.Applying to 5.0.x and newer.