From 1b72e4cdef7670716bdda7b3de1cae85be86b887 Mon Sep 17 00:00:00 2001 From: Swapnil Gawade Date: Fri, 30 Sep 2022 11:59:09 -0400 Subject: [PATCH] Fix default consumer timeout The default timeout does not check for zero. This results in default timeout to be set as zero in case a zero is passed in the request param. --- .../java/io/confluent/kafkarest/v2/KafkaConsumerReadTask.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kafka-rest/src/main/java/io/confluent/kafkarest/v2/KafkaConsumerReadTask.java b/kafka-rest/src/main/java/io/confluent/kafkarest/v2/KafkaConsumerReadTask.java index d64c6feaff..67ad461de8 100644 --- a/kafka-rest/src/main/java/io/confluent/kafkarest/v2/KafkaConsumerReadTask.java +++ b/kafka-rest/src/main/java/io/confluent/kafkarest/v2/KafkaConsumerReadTask.java @@ -70,7 +70,8 @@ public KafkaConsumerReadTask( this.maxResponseBytes = Math.min(maxBytes, config.getLong(KafkaRestConfig.CONSUMER_REQUEST_MAX_BYTES_CONFIG)); Duration defaultRequestTimeout = - parent.getConsumerInstanceConfig().getRequestWaitMs() != null + parent.getConsumerInstanceConfig().getRequestWaitMs() != null + && parent.getConsumerInstanceConfig().getRequestWaitMs() > 0 ? Duration.ofMillis(parent.getConsumerInstanceConfig().getRequestWaitMs()) : Duration.ofMillis(config.getInt(KafkaRestConfig.CONSUMER_REQUEST_TIMEOUT_MS_CONFIG)); this.requestTimeout =