Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixed host issue for kafka-interactive-queries #128
Currently, any string provided as the APPLICATION_HOST will start the REST Service on localhost (0.0.0.0).
This fix will enhance the functionality by-
Issue link: #127
It looks like @nehabhardwaj01 hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here.
Once you've signed reply with
Appreciation of efforts,
bbejeck left a comment •
Overall the change LGTM as well. I've left one minor comment about loading sample songs for the test. I have one suggestion for mitigation the race condition of grabbing a free port before binding, but it's just a suggestion off the top of my head. Since we've been living with this race condition for a while I'm not sure it's enough to hold up merging. It would probably be good to get on more opinion.