Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONFLUENT: Jenkins gradle exit 1 on executor failure, 0 on test failu… #215

Merged
merged 1 commit into from Jul 21, 2019

Conversation

gwenshap
Copy link

@gwenshap gwenshap commented Jul 21, 2019

…re (#531)

We wish to return a yellow build on a test failure, but wish to fail the
build completely when the gradle executors do not finish cleanly. This
change will achieve that.
(cherry picked from commit 334acf48d40e6a3c627cb71990fa91e1616e4921)

-- This change also reduces the max forks from 6 to 4, to improve stability of builds.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's mention the reduction to 4 forks in the PR/commit description too.

…re (#531)

We wish to return a yellow build on a test failure, but wish to fail the
build completely when the gradle executors do not finish cleanly. This
change will achieve that.
(cherry picked from commit 334acf48d40e6a3c627cb71990fa91e1616e4921)

-- This also changes max number of forks to 4, to improve build stability
@gwenshap
Copy link
Author

force pushed to amend the commit message.

@gwenshap gwenshap merged commit 10ab08b into master Jul 21, 2019
jsancio pushed a commit that referenced this pull request Sep 13, 2019
…tStore (#215)

Enable configuration of S3 SSE algorithm for data at rest
@ijuma ijuma deleted the jenkins_fix branch January 25, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants