From 894452637a35de1ae5eb34aa19cc0b6b4ae9c478 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sergio=20Pe=C3=B1a?= Date: Tue, 25 Jun 2019 11:10:33 -0500 Subject: [PATCH] Remove KsqlException from KsqlAuthorizationProvider interface --- .../ksql/rest/server/filters/KsqlAuthorizationFilter.java | 2 +- .../rest/server/security/KsqlAuthorizationProvider.java | 7 ++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/filters/KsqlAuthorizationFilter.java b/ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/filters/KsqlAuthorizationFilter.java index bbca5ef02a8f..7167f1419a63 100644 --- a/ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/filters/KsqlAuthorizationFilter.java +++ b/ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/filters/KsqlAuthorizationFilter.java @@ -47,7 +47,7 @@ public void filter(final ContainerRequestContext requestContext) { try { authorizationProvider.checkEndpointAccess(user, method, path); } catch (final Throwable t) { - log.warn(String.format("User:%s is denied access \"%s %s\"", user, method, path), t); + log.warn(String.format("User:%s is denied access to \"%s %s\"", user, method, path), t); requestContext.abortWith(Errors.accessDenied(t.getMessage())); } } diff --git a/ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/security/KsqlAuthorizationProvider.java b/ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/security/KsqlAuthorizationProvider.java index 2adb1285e84d..fb9b13915c53 100644 --- a/ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/security/KsqlAuthorizationProvider.java +++ b/ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/security/KsqlAuthorizationProvider.java @@ -15,8 +15,6 @@ package io.confluent.ksql.rest.server.security; -import io.confluent.ksql.util.KsqlException; - import java.security.Principal; /** @@ -28,8 +26,7 @@ public interface KsqlAuthorizationProvider { * * @param user The user who is requesting access to the endpoint * @param method The endpoint method used, i.e. POST, GET, DELETE - * @param path The endpoint path to access, i.e. "/ksql", "/ksql/terminate", "/query" - * @throws KsqlException for access denied or any other authorization error + * @param path The endpoint path to access, i.e. "/ksql", "/ksql/terminate", "/query"* */ - void checkEndpointAccess(Principal user, String method, String path) throws KsqlException; + void checkEndpointAccess(Principal user, String method, String path); }