Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in Avro schema cleanup during drop source #2537

Merged
merged 4 commits into from Mar 14, 2019

Conversation

Projects
None yet
3 participants
@vcrfxia
Copy link
Contributor

commented Mar 7, 2019

Description

If a DROP STREAM ... DELETE TOPIC command is issued on an Avro stream, the expected behavior is to not only delete the topic backing the stream, but also clean up the schema associated with the stream (from Schema Registry). However, this currently doesn't happen if the ksqlTopicName (i.e., KsqlTopic#topicName) and kafkaTopicName (i.e., KsqlTopic#kafkaTopicName) for the stream don't match. The reason for this bug is because the subject name of the Avro schema is determined by the kafkaTopicName, but the schema cleanup code currently tries to clean up schemas found using the ksqlTopicName. This PR fixes the bug.

Testing done

Updated unit tests, added an integration test.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@vcrfxia vcrfxia requested a review from confluentinc/ksql as a code owner Mar 7, 2019

@hjafarpour
Copy link
Member

left a comment

LGTM.

@vcrfxia vcrfxia changed the base branch from master to 5.2.x Mar 7, 2019

@vcrfxia vcrfxia force-pushed the vcrfxia:avro-schema-bug branch from be560d8 to a428e68 Mar 7, 2019

@spena

spena approved these changes Mar 8, 2019

Copy link
Member

left a comment

Thanks, it looks good

@vcrfxia vcrfxia referenced this pull request Mar 11, 2019

Merged

Fix bug in Avro schema cleanup during drop source (5.0.x) #2549

0 of 2 tasks complete

@vcrfxia vcrfxia merged commit f810768 into confluentinc:5.2.x Mar 14, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.