Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename `topicName` to `ksqlTopicName` in KsqlTopic class. #2571

Merged
merged 2 commits into from Mar 15, 2019

Conversation

Projects
None yet
3 participants
@hjafarpour
Copy link
Member

hjafarpour commented Mar 14, 2019

KsqlTopic had a fields called 'topicNamewhich referred to the name ofKsqlTopicobject and another field,kafkaTopicNamewhich refers to the name of the kafka topic associated with this KsqlTopic.topicNamehas cause mistakes and was used instead of kafkaTopicName before. This change clarifies thetopicNamefield name indicating that it is notkafkaTopicName`!

@hjafarpour hjafarpour requested a review from confluentinc/ksql Mar 14, 2019

@@ -93,7 +93,7 @@ public abstract StructuredDataSource cloneWithTimeExtractionPolicy(
TimestampExtractionPolicy policy);

public String getTopicName() {

This comment has been minimized.

Copy link
@vcrfxia

vcrfxia Mar 14, 2019

Contributor

Can we rename this one too please?

This comment has been minimized.

Copy link
@hjafarpour

hjafarpour Mar 14, 2019

Author Member

Yes, renamed that one too!

@vcrfxia vcrfxia requested a review from confluentinc/ksql Mar 14, 2019

@vcrfxia
Copy link
Contributor

vcrfxia left a comment

Thanks @hjafarpour -- I think this will save us a lot of confusion moving forward! LGTM.

@vcrfxia vcrfxia requested a review from confluentinc/ksql Mar 14, 2019

@spena

spena approved these changes Mar 14, 2019

Copy link
Member

spena left a comment

Aa that topic name, I got confused too.
LGTM

@hjafarpour hjafarpour merged commit 02c749a into confluentinc:master Mar 15, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@vcrfxia vcrfxia referenced this pull request Mar 15, 2019

Merged

Minor: code clean-up promised as follow-up to #2526 #2576

0 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.