Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix Joining on ROWKEY #2735
This continues the work to clean up key field handling in the existing code.
This PR addresses issues when joining by ROWKEY.
Extensive JSON and Unit tests added.
agavra left a comment
Really nice change @big-andy-coates. Took me a while to get my head wrapped around exactly what was changing despite it being, in essence, a pretty simple change... The data flow has such high complexity around this part of the code I wish there was a simpler way to model it!