Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config for custom metrics tags (5.3.x) #2996

Merged
merged 2 commits into from Jul 19, 2019

Conversation

@vcrfxia
Copy link
Contributor

commented Jun 20, 2019

Description

Backport changes from #2971 to 5.3.x.

Testing done

Updated unit tests.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@vcrfxia vcrfxia requested review from JimGalasyn and confluentinc/ksql as code owners Jun 20, 2019

@vcrfxia vcrfxia referenced this pull request Jun 20, 2019
0 of 2 tasks complete
@agavra
agavra approved these changes Jun 20, 2019
@JimGalasyn
Copy link
Member

left a comment

LGTM!

@vcrfxia vcrfxia changed the title Add config for custom metrics tags (5.3.x) feat: add config for custom metrics tags (5.3.x) Jul 19, 2019

@vcrfxia vcrfxia merged commit 76f5590 into confluentinc:5.3.x Jul 19, 2019

2 checks passed

Semantic Pull Request ready to be squashed
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@vcrfxia vcrfxia deleted the vcrfxia:custom-metrics-tags-5.3 branch Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.