Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter null entries before creating KafkaConfigStore #3147

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@agavra
Copy link
Contributor

commented Jul 30, 2019

Description

Our standalone module goes through KafkaConfigStore, which in turn uses ImmutableMap. The ImmutableMap requires all values in a map to be non-null. Since we added a few configurations with null defaults - we need to filter them out here.

Testing done

Updated tests to remove the filterNullEntries and manually spun up KSQL standalone.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@agavra agavra added the bug label Jul 30, 2019

@agavra agavra requested a review from confluentinc/ksql as a code owner Jul 30, 2019

@rodesai
Copy link
Contributor

left a comment

LGTM

@vcrfxia
Copy link
Contributor

left a comment

LGTM. Thanks @agavra !

@agavra agavra merged commit 2852af1 into confluentinc:5.3.x Jul 30, 2019

2 checks passed

Semantic Pull Request ready to be squashed
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@agavra agavra deleted the agavra:fix_null_map_entries branch Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.