Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allow for more specific error messages to be sent when the server is unavailable #3154

Merged

Conversation

@stevenpyzhang
Copy link
Contributor

commented Jul 31, 2019

Description

Instead of only receiving an error string from precondition checks, receives a KsqlErrorMessage object that can be directly passed along to anyone who checks serverState while it's in State.Initializing

Testing done

Fixed unit tests that broke and ran them to verify they passed
mvn clean install
Tested in CPD

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@stevenpyzhang stevenpyzhang requested a review from confluentinc/ksql as a code owner Jul 31, 2019

@ConfluentCLABot

This comment has been minimized.

Copy link

commented Jul 31, 2019

@confluentinc It looks like @stevenpyzhang just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@stevenpyzhang stevenpyzhang force-pushed the stevenpyzhang:acls-error-code-change-5-3 branch 3 times, most recently from d82ee1a to 1e98b47 Jul 31, 2019

@stevenpyzhang stevenpyzhang requested review from vcrfxia and rodesai Jul 31, 2019

@vcrfxia
vcrfxia approved these changes Aug 1, 2019
Copy link
Contributor

left a comment

LGTM with one nit inline. Thanks @stevenpyzhang !

@vcrfxia vcrfxia requested a review from confluentinc/ksql Aug 1, 2019

@stevenpyzhang stevenpyzhang force-pushed the stevenpyzhang:acls-error-code-change-5-3 branch from 1e98b47 to fd50682 Aug 1, 2019

@rodesai
rodesai approved these changes Aug 1, 2019
Copy link
Contributor

left a comment

LGTM

@stevenpyzhang stevenpyzhang force-pushed the stevenpyzhang:acls-error-code-change-5-3 branch from fd50682 to 95ffc4e Aug 1, 2019

@stevenpyzhang stevenpyzhang merged commit 828418e into confluentinc:5.3.x Aug 1, 2019

2 checks passed

Semantic Pull Request ready to be squashed
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
stevenpyzhang added a commit to stevenpyzhang/ksql that referenced this pull request Aug 5, 2019
stevenpyzhang added a commit to stevenpyzhang/ksql that referenced this pull request Aug 6, 2019
stevenpyzhang added a commit that referenced this pull request Aug 6, 2019
chore: Fix merge revert (#3173)
*  refactor: allow for more specific error messages to be sent when the server is unavailable (#3154)

* docs: fix broken internal links in serialization topic (#3161)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.